[EuiIcon] Fix setState errors when in React.StrictMode
#5899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
eui-icon-early-setstate
branch
from
8e3e56b to
d98b88d
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5899/ |
thompsongl
approved these changes
May 12, 2022
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM; confirmed the fix with a local build and StrictMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #4783
This PR is essentially a copy of @Phizzard's work in #4910. The original PR fixes the issue but unfortunately was closed before it could be merged.
QA
Repro steps
src-docs/src/views/icon/icons.js, add<React.StrictMode>in place of the<>wrapper around the exported componentBefore
After
Checklist
- [ ] Added or updated jest and cypress tests