Add support of Data View switching for Agg-Based visualizations by alexwizp · Pull Request #132184 · elastic/kibana

alexwizp · 2022-05-12T20:16:17Z

Summary

This PL adds the ability to change the Data View for already saved classic visualizations. These changes are related to the Unified Search initiative and continue to implement the overall design in line with other plugins (Lens, Discover, etc.)

Screens

Screen.Recording.2022-05-13.at.12.08.50.PM.mov

alexwizp · 2022-05-13T13:29:47Z

@elasticmachine merge upstream

ghudgins · 2022-05-13T19:51:02Z

really like the behavior. the only thing that's weird now is the duplication of the data view name. I see why it's nice to have it over on the right (that's where it used to be too) but it does make the edit action feel out of place a bit. just minor feedback - removing this is also a bit strange when it comes for needing a place to unlink the saved search so I think this PR could still be merged without a solution to the double data view name issue.

as a complete aside this makes me yearn for the collapsable field list in Lens too :D (and the broader unification of discover & lens' field lists someday)

elasticmachine · 2022-05-16T08:17:08Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

alexwizp · 2022-05-16T08:21:12Z

@elasticmachine merge upstream

nlatipov · 2022-05-16T09:05:57Z

LGTM!, code review only

alexwizp · 2022-05-17T08:54:40Z

@elasticmachine merge upstream

flash1293

Looks mostly good, some small nits

flash1293 · 2022-05-16T17:28:59Z

src/plugins/visualizations/public/embeddable/visualize_embeddable.tsx

    this.subscriptions.push(this.handler.loading$.subscribe(this.onContainerLoading));
    this.subscriptions.push(this.handler.render$.subscribe(this.onContainerRender));

+    this.subscriptions.push(


Why this change?

I need to show error in EmbeddableVis. Without this, we will not render anything, it will just be a white screen

How did it work before?

Ok... I've reproduced field error on the previous implementation. It's not working. User see loading indicator

Screen.Recording.2022-05-17.at.3.16.57.PM.mov

flash1293 · 2022-05-16T17:29:55Z

src/plugins/vis_default_editor/public/components/sidebar/state/reducers.ts


      case EditorStateActionTypes.DISCARD_CHANGES: {
-        return initEditorState(action.payload);
+        return initEditorState(action.payload.vis);


Why this change?

I expanded payload in the previous solution, then it turned out to be unnecessary, but it seems to me that passing as an object is more correct and I decided to leave it like this.

Plus I see now all actions looks the same, all payloads wrapped into object.

flash1293 · 2022-05-17T11:05:36Z

src/plugins/visualizations/public/visualize_app/utils/use/use_data_view_updates.ts

+    let stateUpdatesSubscription: Subscription;
+
+    if (appState && visInstance) {
+      const syncDataView = async ({ dataView }: VisualizeAppState, setDirty = true) => {


unused flag?

right, thanks!

kibana-ci · 2022-05-17T12:43:15Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visualizations`	218	219	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visDefaultEditor`	142.4KB	142.4KB	+10.0B
`visualizations`	165.9KB	167.8KB	+1.9KB
total			+1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeGauge`	9.9KB	9.9KB	+48.0B
`visTypeHeatmap`	10.4KB	10.4KB	+24.0B
`visTypeMetric`	8.8KB	8.8KB	+24.0B
`visTypePie`	8.0KB	8.0KB	+24.0B
`visTypeTable`	15.3KB	15.3KB	+24.0B
`visTypeTagcloud`	5.8KB	5.9KB	+24.0B
`visTypeXy`	43.3KB	43.4KB	+96.0B
`visualizations`	46.5KB	46.5KB	-1.0B
total			+263.0B

History

💔 Build #45273 failed 84776e6
💚 Build #45229 succeeded 61ae265
💚 Build #44799 succeeded 6244ef9
💚 Build #44688 succeeded c51500b
💔 Build #44682 failed 8280970
💚 Build #44675 succeeded b14469e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

flash1293

LGTM, works as expected!

…tic#132184) * Add support of Data View switching for Agg-Based visualizations * fix CI * add use_date_view_updates * implement sync with state * cleanup * cleanup * cleanup * Update index.ts * fix PR comments * Update use_data_view_updates.ts * Update use_data_view_updates.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* wip I * add alert table state in case * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * add new API to get FeatureID form registrationContext and update UI to use this new API * rm dead code * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove unnecessary memo * adds tests for case view helpers * Move http call to API and add tests for getFeatureIds * fix type + unit test * add unit tests + cleanup * add new api integration test for _feature_ids * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Fix small type creating typescript slowness * remove console log * use import type for validfeatureId * force any to improve typescript performance * Update APM (#132270) Co-authored-by: Renovate Bot <bot@renovateapp.com> * [ResponseOps][Docs] Updating ServiceNow docs with OAuth setup instructions (#131344) * Updating ServiceNow docs. Need screenshots * Adding screenshots * Fix nested screenshots and lists * Tweaks and screenshots * Updates * blergh * Apply suggestions from code review Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Apply suggestions from code review Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> * Show polling options when 'Data streams' option is selected in the Console Settings modal. (#132277) * [Osquery] Make Osquery All with All base privillege (#130523) * [XY] Add normalizeTable function to correct works with esdocs (#131917) * Add normalizeTable function to correct works with esdocs * Fix types * Fix types * Fix CI * Fix CI * Some fixes * Remove fallback with min/max value for domain * Added tests * Some refactoring Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> * [Osquery] Add default osquery_saved_query objects (#129461) * [Unified Search] Show error message for invalid date filter value (#131290) * feat: added show error message for invalid date * refact: move logic in HOC * feat: refactoring code and added translation * refact show error * refact: show error message * refact: remove translation * refactor: changed menu for show FilterEdit * fix: open/close popover * feat: field.type => KBN_FIELD_TYPES * feat: remove extra code with with input check and refactored filter item * feat: added tests and refactoring code * refact: getFieldValidityAndErrorMessage * feat: return isInvalid checking in valur input type for string, ip * Update navigation landing pages to use appLinks config (#132027) * Update navigation landing pages to use appLinks config * Please code review * align app links changes * Update links descriptions * Rollback title changes * Fix wrong links descriptions * Fix unit tests * Fix description Co-authored-by: semd <sergi.massaneda@elastic.co> * [Cloud Posture] add resource findings page flyout (#132243) * [Discover] Add a tour for Document Explorer (#131125) * [Discover] Add "Take a tour" button to the Document Explorer callout * [Discover] Tmp * [Discover] Add a first Document Explorer tour step * [Discover] Add other Document Explorer tour steps * [Discover] Update tour steps positioning * [Discover] Add gifs to tour steps * [Discover] Refactor how tour steps are registered * [Discover] Add new step to the tour. Update tour steps text. * [Discover] Improve steps positioning * [Discover] Fix positioning for Add field step * [Discover] Add icons to tour steps * [Discover] Reorganize components * [Discover] Skip Columns step when it's not available * [Discover] Rename components * [Discover] Add some tests * [Discover] Fix positioning * [Discover] Fix props * [Discover] Render steps only if the tour is active * [Discover] Update gifs * [Discover] Add image alt text for gifs * [Discover] Tag the Take tour button * [Discover] Update text and tests * [Discover] Add more tests * [Discover] Rename assets directory * [Discover] Fix tour in mobile view. Improve steps positioning and animation. * [Discover] Update text in tour steps * [Discover] Update sort.gif * [Discover] Update image width * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * [Discover] Update sort.gif * [Discover] Fix code style Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [XY] Add `minTimeBarInterval` arg (#128726) * Added `xAxisInterval` arg * Add validation * Add tests * Rename xAxisInterval to minTimeBarInterval and add validation * Fix imports * Add tests to validation * Fix conflicts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * do not use barrel imports * do not use barrel import * do not use barrel import * do not use barrel imports * do not use barrel import * import types * Add tests * Fix cases bundle size * Add more tests * [Fleet] Add new API to get current upgrades (#132276) * Add support of Data View switching for Agg-Based visualizations (#132184) * Add support of Data View switching for Agg-Based visualizations * fix CI * add use_date_view_updates * implement sync with state * cleanup * cleanup * cleanup * Update index.ts * fix PR comments * Update use_data_view_updates.ts * Update use_data_view_updates.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Security Solution] Responsive styling fixes (#131951) * [Discover] Add Analytics No Data Page (#131965) * [Discover] Add Analytics No Data Page * Make showEmptyPrompt parameter optional * Remove unused import * Remove unnecessary test * Fix test * Update failing test? * Update failing test * Changing the order of functional tests * Fix error handling * Addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Remove barrel export from public index file * remove barrel export * Re-export missing exports * Turn off feature flag Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Esteban Beltran <esteban.beltran@elastic.co> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: CJ Cenizal <cj.cenizal@elastic.co> Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com> Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Co-authored-by: Nodir Latipov <nodir.latypov@gmail.com> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: semd <sergi.massaneda@elastic.co> Co-authored-by: Or Ouziel <or.ouziel@elastic.co> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Maja Grubic <maja.grubic@elastic.co>

Add support of Data View switching for Agg-Based visualizations

fbf8341

alexwizp force-pushed the unified-search-agg-based branch from 3dda5ff to fbf8341 Compare May 13, 2022 09:07

kibanamachine and others added 6 commits May 13, 2022 08:29

Merge branch 'main' into unified-search-agg-based

fbbaf47

fix CI

b3c8add

add use_date_view_updates

b14469e

implement sync with state

9c50425

cleanup

4a07c10

cleanup

55202ad

alexwizp requested a review from nlatipov May 13, 2022 16:44

alexwizp added 2 commits May 13, 2022 19:47

cleanup

8280970

Update index.ts

c51500b

alexwizp marked this pull request as ready for review May 16, 2022 08:16

alexwizp requested a review from a team as a code owner May 16, 2022 08:16

alexwizp self-assigned this May 16, 2022

alexwizp added v8.3.0 Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels May 16, 2022

alexwizp added release_note:feature Makes this part of the condensed release notes backport:skip This PR does not require backporting labels May 16, 2022

kibanamachine and others added 2 commits May 16, 2022 03:21

Merge branch 'main' into unified-search-agg-based

eaa2802

fix PR comments

6244ef9

nlatipov approved these changes May 16, 2022

View reviewed changes

Merge branch 'main' into unified-search-agg-based

61ae265

flash1293 reviewed May 17, 2022

View reviewed changes

alexwizp added 2 commits May 17, 2022 14:24

Update use_data_view_updates.ts

84776e6

Update use_data_view_updates.ts

ca102ae

flash1293 approved these changes May 17, 2022

View reviewed changes

alexwizp merged commit 1bb63f8 into elastic:main May 17, 2022

dokmic mentioned this pull request Jun 24, 2022

Lens error tooltips: support copy/paste of the error message #128133

Closed

Conversation

alexwizp commented May 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screens

Uh oh!

alexwizp commented May 13, 2022

Uh oh!

ghudgins commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented May 16, 2022

Uh oh!

alexwizp commented May 16, 2022

Uh oh!

nlatipov commented May 16, 2022

Uh oh!

alexwizp commented May 17, 2022

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alexwizp commented May 12, 2022 •

edited

Loading

ghudgins commented May 13, 2022 •

edited

Loading