Skip to content

[RAM] Alert Table from triggers_actions_ui plugin#131883

Merged
XavierM merged 58 commits intoelastic:mainfrom
XavierM:alert_hook
May 17, 2022
Merged

[RAM] Alert Table from triggers_actions_ui plugin#131883
XavierM merged 58 commits intoelastic:mainfrom
XavierM:alert_hook

Conversation

@XavierM
Copy link
Contributor

@XavierM XavierM commented May 10, 2022 •
edited by cnasikas
Loading

Summary

  • Add a hook to fetch alerts
  • Create a state alert component to manage all the plumbing of the alert table
  • insert the alert table in case

image

Checklist

Release note

View all alerts attached to a case in the alerts table. The feature is experimental.

@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Cases Cases feature v8.3.0 labels May 10, 2022
academo
academo reviewed May 10, 2022
View reviewed changes
academo
academo reviewed May 10, 2022
View reviewed changes
academo
academo reviewed May 10, 2022
View reviewed changes
academo
academo reviewed May 10, 2022
View reviewed changes
x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.tsx
@@ -133,20 +129,12 @@ const AlertsTable: React.FunctionComponent<AlertsTableProps> = (props: AlertsTab
<EuiDataGrid
aria-label="Alerts table"
data-test-subj="alertsTable"
Copy link
Contributor

@academo academo May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this data-test-subj a prop.

@academo
Copy link
Contributor

academo commented May 10, 2022

so far looking good and I like how simple to use is on the cases side! good work.

I know this is a draft PR but nevertheless pointing at missing:

  • jest tests for all new hooks, component and helpers.
  • do not forget to set false to feature flags and code flags.

cnasikas
cnasikas reviewed May 10, 2022
View reviewed changes
cnasikas
cnasikas reviewed May 10, 2022
View reviewed changes
@fkanout fkanout mentioned this pull request May 10, 2022
Closed
@academo academo removed request for a team, joeypoon and paul-tavares May 17, 2022 12:24
academo
academo reviewed May 17, 2022
View reviewed changes
cnasikas and others added 11 commits May 17, 2022 18:07
@cnasikas
Add more tests
62bb244
@cnasikas
Merge branch 'alert_hook' of github.com:XavierM/kibana into alert_hook
20f58cb
@nchaulet
[Fleet] Add new API to get current upgrades (elastic#132276)
f40928b
@alexwizp @kibanamachine
Add support of Data View switching for Agg-Based visualizations (elas…
fc6cd8c 
…tic#132184)

* Add support of Data View switching for Agg-Based visualizations

* fix CI

* add use_date_view_updates

* implement sync with state

* cleanup

* cleanup

* cleanup

* Update index.ts

* fix PR comments

* Update use_data_view_updates.ts

* Update use_data_view_updates.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stephmilovic
[Security Solution] Responsive styling fixes (elastic#131951)
6bf622a
@kibanamachine
[Discover] Add Analytics No Data Page (elastic#131965)
6202f2f 
* [Discover] Add Analytics No Data Page

* Make showEmptyPrompt parameter optional

* Remove unused import

* Remove unnecessary test

* Fix test

* Update failing test?

* Update failing test

* Changing the order of functional tests

* Fix error handling

* Addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Remove barrel export from public index file
1bf83a3
remove barrel export
09f7ca1
Merge remote-tracking branch 'upstream/main' into alert_hook
f8b4913
Re-export missing exports
afb43aa
Turn off feature flag
f44390c
@kibana-ci
Copy link

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 427 431 +4
triggersActionsUi 380 385 +5
total +9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 169 174 +5
triggersActionsUi 383 368 -15
total -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 298.3KB 299.8KB +1.5KB
triggersActionsUi 750.1KB 772.2KB +22.1KB
total +23.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ruleRegistry 8 9 +1
triggersActionsUi 31 34 +3
total +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 112.1KB 112.2KB +125.0B
triggersActionsUi 103.2KB 103.2KB -19.0B
total +106.0B
Unknown metric groups

API count

id before after diff
ruleRegistry 196 202 +6
triggersActionsUi 397 382 -15
total -9

async chunk count

id before after diff
triggersActionsUi 81 82 +1

ESLint disabled line counts

id before after diff
cases 80 81 +1
triggersActionsUi 172 173 +1
total +2

Total ESLint disabled count

id before after diff
cases 96 97 +1
triggersActionsUi 178 179 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 859a795 into elastic:main May 17, 2022
This was referenced May 19, 2022
Open
Closed
@cnasikas cnasikas added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2022
This was referenced Jun 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

+1 more reviewer

@academo academo academo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Cases Cases feature release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.