Skip to content

[SecuritySolution] Remove the cell hovers actions for agent status#130042

Merged
michaelolo24 merged 2 commits intoelastic:mainfrom
janmonschke:security/broken-agent-status-investigate-in-timeline
Apr 12, 2022
Merged

[SecuritySolution] Remove the cell hovers actions for agent status#130042
michaelolo24 merged 2 commits intoelastic:mainfrom
janmonschke:security/broken-agent-status-investigate-in-timeline

Conversation

@janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Apr 12, 2022 •
edited
Loading

Summary

As discussed in #127010, the agent.status cell should not have hover actions since the user cannot take actions on that field:

Screen.Recording.2022-04-12.at.18.55.35.mov

Checklist

@janmonschke
fix: remove the cell actions for agent status
2f1bd4d 
As discussed in elastic#127010, the agent.status should not have hover actions
@janmonschke janmonschke added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.2.0 v8.3.0 labels Apr 12, 2022
@janmonschke janmonschke requested a review from a team as a code owner April 12, 2022 16:58
@janmonschke janmonschke self-assigned this Apr 12, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 12, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link

kibana-ci commented Apr 12, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +28.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

michaelolo24
michaelolo24 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything looks great. Thanks for doing this work Jan!

@michaelolo24
Copy link
Contributor

michaelolo24 commented Apr 12, 2022

Merging so it makes it for the next BC!

@michaelolo24 michaelolo24 merged commit 9f37de5 into elastic:main Apr 12, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 12, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
@janmonschke
[SecuritySolution] Remove the cell hovers actions for agent status (#…
e452556 
…130042)

* fix: remove the cell actions for agent status

As discussed in #127010, the agent.status should not have hover actions

* chore: use object-lookup instead of array.includes

(cherry picked from commit 9f37de5)
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 12, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 12, 2022
@kibanamachine @janmonschke
[SecuritySolution] Remove the cell hovers actions for agent status (#…
c61787f 
…130042) (#130056)

* fix: remove the cell actions for agent status

As discussed in #127010, the agent.status should not have hover actions

* chore: use object-lookup instead of array.includes

(cherry picked from commit 9f37de5)

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
This was referenced Apr 13, 2022
Closed
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 13, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/soft-…
26b64f9 
…disable-server-side

* 'main' of github.com:elastic/kibana: (35 commits)
  [Uptime] remove latency limit warnings when using monitor management (elastic#129597)
  [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992)
  Paramaterized Discover tests (elastic#129684)
  [Security Solution][Investigations] - Minor bug fixes (elastic#130054)
  [DOCS} Adds technical preview to Lens annotations (elastic#130058)
  [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773)
  [Security Solutions] Adds API docs for value lists (elastic#129962)
  [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045)
  chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051)
  [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042)
  Upgrade RxJS to 7 (elastic#129087)
  [SecuritySolution] Clean up CaseContext (elastic#130036)
  Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)"
  Use RuleDataReader to query for threshold signal history (elastic#129763)
  Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769)
  Upgrade EUI to v54.0.0 (elastic#129653)
  [Security Solution] More Ransomware exceptionable fields (elastic#130039)
  Add e2e for the apm integration policy form (elastic#129860)
  chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)
  [ML] Fix Single Metric Viewer chart failing to load if no points during calendar event (elastic#130000)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 13, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/poc-p…
d49e398 
…rint-media-attempt-2

* 'main' of github.com:elastic/kibana: (75 commits)
  [Lens] Hide disabled toolbar entries (elastic#129994)
  Fix explore tables don't display data when a global filter is applied (elastic#130024)
  [Console] Add option to disable keyboard shortcuts (elastic#128887)
  [Discover] Update refreshOnClick flaky test (elastic#130001)
  [Uptime] remove latency limit warnings when using monitor management (elastic#129597)
  [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992)
  Paramaterized Discover tests (elastic#129684)
  [Security Solution][Investigations] - Minor bug fixes (elastic#130054)
  [DOCS} Adds technical preview to Lens annotations (elastic#130058)
  [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773)
  [Security Solutions] Adds API docs for value lists (elastic#129962)
  [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045)
  chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051)
  [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042)
  Upgrade RxJS to 7 (elastic#129087)
  [SecuritySolution] Clean up CaseContext (elastic#130036)
  Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)"
  Use RuleDataReader to query for threshold signal history (elastic#129763)
  Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769)
  Upgrade EUI to v54.0.0 (elastic#129653)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/formats/pdf/index.ts
@janmonschke janmonschke mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@janmonschke janmonschke

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.2.0 v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janmonschke @elasticmachine @kibana-ci @michaelolo24 @kibanamachine