Add e2e for the apm integration policy form by kpatticha · Pull Request #129860 · elastic/kibana

kpatticha · 2022-04-10T21:36:30Z

Summary

The e2e tests are focused on the apm integration.
closes #123399

elasticmachine · 2022-04-10T21:36:34Z

Pinging @elastic/apm-ui (Team:apm)

kpatticha · 2022-04-10T21:36:45Z

@elasticmachine merge upstream

kpatticha · 2022-04-11T07:56:15Z

...lugins/apm/ftr_e2e/cypress/integration/power_user/integration_settings/integration_policy.ts

I checked only the required fields here. I think I should write different tests for the form itself.
Let me know your thoughts

I think having an E2E test that asserts that validation is working in general, and then covering the remaining areas with unit tests, is a good balance.

…tion-test

...lugins/apm/ftr_e2e/cypress/integration/power_user/integration_settings/integration_policy.ts

x-pack/plugins/apm/public/components/fleet_integration/apm_policy_form/typings.ts

.../ftr_e2e/cypress/integration/read_only_user/integration_settings/apm_server_not_installed.ts

dgieselaar

forgot to press submit on a pending review :)

dgieselaar · 2022-04-11T11:44:46Z

...lugins/apm/ftr_e2e/cypress/integration/power_user/integration_settings/integration_policy.ts

+  });
+
+  describe('creating a new integration policy', () => {
+    beforeEach(() => {


This feels llike it's mixing assertions with input. IMHO the assertions belong in a test, the input in the body of a beforeEach

I agree, it seems cleaner the assertions to be in the test
1394538

dgieselaar · 2022-04-11T11:50:10Z

...lugins/apm/ftr_e2e/cypress/integration/power_user/integration_settings/integration_policy.ts

+      cy.get('[data-test-subj="integration-card:epr:apm:featured').click();
+      cy.get('[aria-selected="true"]').contains('Elastic APM in Fleet');
+      cy.contains('Elastic APM now available in Fleet!');
+      cy.contains('a', 'APM integration').click();
+      cy.url().should('include', 'app/integrations/detail/apm/overview');
+      cy.get('[data-test-subj="addIntegrationPolicyButton"]')


it's a little hard for me to understand what these statements are actually doing. perhaps it would be benefit by abstracting them into functions or leaving comments?

I updated it should be more obvious now
#1394538

dgieselaar · 2022-04-11T11:52:26Z

...lugins/apm/ftr_e2e/cypress/integration/power_user/integration_settings/integration_policy.ts

I think having an E2E test that asserts that validation is working in general, and then covering the remaining areas with unit tests, is a good balance.

cauemarcondes

LGTM

kibana-ci · 2022-04-12T16:49:44Z

💚 Build Succeeded

Test Failures

[job] [logs] OSS CI Group #11 / visualize app visualize ciGroup11 visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.8MB	+235.0B

History

💔 Build #37593 failed 5e342efee0bbe97e68d19cd25eb5d86f5b514cd7
💔 Build #37500 failed 1a3fd6e
💔 Build #37189 failed 1e3f911
💔 Build #37143 failed 73fa8680fa4ad325dbdf84ad693a7eaa51b11f08

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…disable-server-side * 'main' of github.com:elastic/kibana: (35 commits) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) [Security Solution] More Ransomware exceptionable fields (elastic#130039) Add e2e for the apm integration policy form (elastic#129860) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021) [ML] Fix Single Metric Viewer chart failing to load if no points during calendar event (elastic#130000) ... # Conflicts: # x-pack/plugins/screenshotting/server/screenshots/index.test.ts

kpatticha added 2 commits April 7, 2022 10:10

Grant fleet privileges and capabilities to power user

c3be0d4

Add e2e for integration policy

5447af0

kpatticha requested a review from a team April 10, 2022 21:36

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Apr 10, 2022

kpatticha added backport:skip This PR does not require backporting v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 10, 2022

kpatticha commented Apr 11, 2022

View reviewed changes

Fix selector for Tail-based

1b77ca8

kpatticha force-pushed the add-apm-integration-test branch from 73fa868 to 1b77ca8 Compare April 11, 2022 08:20

Merge branch 'main' of github.com:elastic/kibana into add-apm-integra…

1e3f911

…tion-test

cauemarcondes requested changes Apr 11, 2022

View reviewed changes

kpatticha added 2 commits April 12, 2022 08:39

Remove e2e releated to Fleet code

52f4d25

Decouple tests

1a3fd6e

kpatticha requested a review from cauemarcondes April 12, 2022 07:38

kpatticha changed the title ~~Add apm integration test~~ Add e2e for the apm integration policy form Apr 12, 2022

dgieselaar reviewed Apr 12, 2022

View reviewed changes

Clean up assertion

1394538

kpatticha requested a review from a team as a code owner April 12, 2022 12:17

cauemarcondes approved these changes Apr 12, 2022

View reviewed changes

jbudz approved these changes Apr 12, 2022

View reviewed changes

Fix flaky test

1641228

kpatticha force-pushed the add-apm-integration-test branch from 5e342ef to 1641228 Compare April 12, 2022 14:46

kpatticha merged commit 8022b0a into elastic:main Apr 12, 2022

Conversation

kpatticha commented Apr 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Apr 10, 2022

Uh oh!

kpatticha commented Apr 10, 2022

Uh oh!

kpatticha Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

dgieselaar Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgieselaar left a comment

Choose a reason for hiding this comment

Uh oh!

dgieselaar Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

kpatticha Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgieselaar Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

kpatticha Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

dgieselaar Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Apr 12, 2022

💚 Build Succeeded

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kpatticha commented Apr 10, 2022 •

edited

Loading

kpatticha Apr 12, 2022 •

edited

Loading