Skip to content

[7.17] [build] Only use buildx if cross compiling (#128560)#129781

Merged
jbudz merged 1 commit intoelastic:7.17from
jbudz:backport/pr-128560-7.17
Apr 7, 2022
Merged

[7.17] [build] Only use buildx if cross compiling (#128560)#129781
jbudz merged 1 commit intoelastic:7.17from
jbudz:backport/pr-128560-7.17

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Apr 7, 2022

  • [build] Only use buildx if cross compiling

  • reuse variable

  • fix conditional

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional
@jbudz jbudz added backport This PR is a backport of another PR ci:build-os-packages labels Apr 7, 2022
@jbudz jbudz self-assigned this Apr 7, 2022
@jbudz jbudz enabled auto-merge (squash) April 7, 2022 17:31
@jbudz jbudz merged commit fc6ea53 into elastic:7.17 Apr 7, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jbudz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:build-os-packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants