[build] Only use buildx if cross compiling#128560
Merged
jbudz merged 6 commits intoelastic:mainfrom Apr 7, 2022
Merged
Conversation
jbudz
added
Team:Operations
1 task
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
added
v8.3.0
v7.17.3
auto-backport
brianseeders
approved these changes
Apr 7, 2022
rockdaboot
approved these changes
Apr 7, 2022
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
Succeeds for me (before: build failure) and LGTM.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 7, 2022
* [build] Only use buildx if cross compiling * reuse variable * fix conditional (cherry picked from commit bcdb0b2)
Contributor
💔 Some backports could not be created
Manual backportTo create the backport manually run: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Apr 7, 2022
* [build] Only use buildx if cross compiling * reuse variable * fix conditional
mitodrummer
pushed a commit
to mitodrummer/kibana
that referenced
this pull request
Apr 7, 2022
* [build] Only use buildx if cross compiling * reuse variable * fix conditional fix jump to nested entity_id. also defaulting verbose mode to OFF
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2022
jbudz
added a commit
that referenced
this pull request
Apr 7, 2022
Contributor
Author
|
7.17: fc6ea53 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#128272 wrongly assumed that
docker buildxis available for all docker installs. This reverts back to the old behavior of usingdocker buildwhen not cross compiling.