Skip to content

[Security Solution] Add a tour showing new rules search capabilities#128849

Closed
banderror wants to merge 1 commit intoelastic:mainfrom
banderror:filter-caps-tour-2
Closed

[Security Solution] Add a tour showing new rules search capabilities#128849
banderror wants to merge 1 commit intoelastic:mainfrom
banderror:filter-caps-tour-2

Conversation

@banderror
Copy link
Contributor

❗ Reopens #128759 created by @xcrzx - it's been reverted in main. ❗

Follow-up to #128245

Summary

  • Added MITRE subtechniques to searchable rule params.
  • Improved search bar copy
  • Added a tour showing new rule search capabilities. Note: the tour implementation differs from what's described in this readme because the EuiTourStep anchor prop added in v52.1.0 is not available yet in Kibana.

Screenshot 2022-03-29 at 15 34 04

@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team v8.2.0 labels Mar 30, 2022
@banderror banderror requested a review from a team as a code owner March 30, 2022 01:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving as original was reverted from main due to a type conflict once merged (please see #128759 (comment)).

@spong
Copy link
Member

spong commented Mar 30, 2022

@banderror @xcrzx -- note, the EUI upgrade that was reverted soon after this one will be merged by an admin once green, so this may still have an issue if CI is 👍 . Best to re-build once #128841 is merged which includes:

Added anchor prop to EuiTourStep to allow for DOM selector attachment (elastic/eui#5696)

@kibana-ci
Copy link

kibana-ci commented Mar 30, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests / value lists user with restricted access role "before each" hook for "Does not allow a t1 analyst user to upload a value list"
  • [job] [logs] Security Solution Tests / value lists user with restricted access role "before each" hook for "Does not allow a t1 analyst user to upload a value list"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3011 3013 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 250.5KB 250.6KB +99.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 510 509 -1
uptime 56 49 -7
total -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

@banderror banderror closed this Mar 30, 2022
@banderror banderror deleted the filter-caps-tour-2 branch March 30, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants