Skip to content

[Security Solution] Add a tour showing new rules search capabilities#128759

Merged
xcrzx merged 1 commit intoelastic:mainfrom
xcrzx:filter-caps-tour
Mar 29, 2022
Merged

[Security Solution] Add a tour showing new rules search capabilities#128759
xcrzx merged 1 commit intoelastic:mainfrom
xcrzx:filter-caps-tour

Conversation

@xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Mar 29, 2022 •
edited
Loading

Follow-up to #128245

Summary

  • Added MITRE subtechniques to searchable rule params.
  • Improved search bar copy
  • Added a tour showing new rule search capabilities. Note: the tour implementation differs from what's described in this readme because the EuiTourStep anchor prop added in v52.1.0 is not available yet in Kibana.

Screenshot 2022-03-29 at 15 34 04

@xcrzx xcrzx added backport:skip This PR does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:Detection Rule Management Security Detection Rule Management Team v8.2.0 labels Mar 29, 2022
@xcrzx xcrzx self-assigned this Mar 29, 2022
@xcrzx xcrzx force-pushed the filter-caps-tour branch from 459cd22 to e478057 Compare March 29, 2022 14:55
@xcrzx xcrzx marked this pull request as ready for review March 29, 2022 15:08
@xcrzx xcrzx requested a review from a team as a code owner March 29, 2022 15:08
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 29, 2022

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 29, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx added the release_note:skip Skip the PR/issue when compiling release notes label Mar 29, 2022
spong
spong approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, verified locally, and code reviewed -- LGTM! 👍

Note I: minor nit on i18n key format

Note II: I don't think sub-technique is mapped as I wasn't able to search for those. No change here needed since the copy doesn't specify sub-technique, but I saw you added it so wanted to comment.

Rule Details:

@xcrzx xcrzx force-pushed the filter-caps-tour branch 2 times, most recently from 034da26 to 1d85726 Compare March 29, 2022 16:31
@xcrzx
Copy link
Contributor Author

xcrzx commented Mar 29, 2022

don't think sub-technique is mapped as I wasn't able to search for those. No change here needed since the copy doesn't specify sub-technique, but I saw you added it so wanted to comment.

Thanks for spotting that, @spong 👍 There was an error in the rule prop name. Should be working fine now.

@xcrzx xcrzx enabled auto-merge (squash) March 29, 2022 16:35
@xcrzx xcrzx force-pushed the filter-caps-tour branch from 1d85726 to def7c4d Compare March 29, 2022 17:32
@xcrzx xcrzx force-pushed the filter-caps-tour branch from def7c4d to f93698f Compare March 29, 2022 19:03
@xcrzx xcrzx merged commit 02a146f into elastic:main Mar 29, 2022
@kibana-ci
Copy link

kibana-ci commented Mar 29, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3004 3006 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 249.4KB 249.5KB +99.0B

History

  • 💔 Build #34601 failed def7c4d572b0f3cd632b3d31c81ebcef0d69ddbc
  • 💔 Build #34575 failed 1d85726a30dd922ccead78e56de565cc172d80da
  • 💔 Build #34514 failed e478057c7c486ab61ff24e512c1fc6439a1995f7
  • 💔 Build #34489 failed 459cd22be01be1741a03826c2ad486f95f6865a9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

tylersmalley added a commit that referenced this pull request Mar 29, 2022
@tylersmalley
Revert "Add a tour showing new rules search capabilities (#128759)"
18c7f4d 
This reverts commit 02a146f.
@tylersmalley
Copy link
Member

tylersmalley commented Mar 29, 2022

Apologies, this needed to be reverted due to a type conflict when merged in with main. Please re-open, thanks.

18c7f4d

@banderror banderror mentioned this pull request Mar 30, 2022
Closed
@banderror
Copy link
Contributor

banderror commented Mar 30, 2022

Reopened in #128849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spong spong spong approved these changes

Assignees

@xcrzx xcrzx

Labels

backport:skip This PR does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes reverted Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xcrzx @elasticmachine @kibana-ci @tylersmalley @banderror @spong