[Watcher] Remove axios dependency in tests#128765
Merged
sabarasaba merged 7 commits intoelastic:mainfrom Mar 31, 2022
Merged
Conversation
sabarasaba
added
Feature:Watcher
Team:Kibana Management
This was referenced Mar 29, 2022
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
Nice job @sabarasaba! Left a couple comments. Let me know what you think.
x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/__jest__/client_integration/watch_status.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the review @alisonelizabeth! I've addressed your points with 7c9f134 |
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
alisonelizabeth
approved these changes
Mar 30, 2022
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback! Latest LGTM.
sabarasaba
added
backport:skip
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Mar 31, 2022
* wip start refactoring tests * commit using @elastic.co * Finish refactoring tests * Remove unused code * Add docs * Address CR changes (cherry picked from commit 1caaaba) # Conflicts: # x-pack/plugins/watcher/__jest__/client_integration/helpers/index.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_create_json.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_create_threshold.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_edit.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_list.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_status.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx # x-pack/plugins/watcher/__jest__/client_integration/watch_edit.test.ts
sabarasaba
added a commit
that referenced
this pull request
Apr 4, 2022
* [Watcher] Remove `axios` dependency in tests (#128765) * wip start refactoring tests * commit using @elastic.co * Finish refactoring tests * Remove unused code * Add docs * Address CR changes (cherry picked from commit 1caaaba) # Conflicts: # x-pack/plugins/watcher/__jest__/client_integration/helpers/index.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_create_json.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_create_threshold.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_edit.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_list.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/helpers/watch_status.helpers.ts # x-pack/plugins/watcher/__jest__/client_integration/watch_create_threshold.test.tsx # x-pack/plugins/watcher/__jest__/client_integration/watch_edit.test.ts * Fix test and linter Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #127966
Summary
In order to upgrade the axios dependency in kibana(see: #111655) we need to switch the tests from this app to use HttpSetup mock instead of axios + sinon server mock, which is technically incorrect but axios just happened to have methods signature similar to HttpSetup.