Upgrade `axios` dependency (`0.21.1` → `0.27.2`). by jbudz · Pull Request #111655 · elastic/kibana

jbudz · 2021-09-08T21:55:08Z

Summary

Upgrade axios dependency (0.21.1 → 0.27.2).

Change log: https://github.com/axios/axios/blob/master/CHANGELOG.md

Note to reviewers: Most of the breaking changes are related to Axios types, but there are some notable breaking changes in 0.25.0 and 0.27.0 releases that you might want to verify in the scope of your specific use cases.

~/dev/kibana(bump-axios*) » npm ls axios
kibana@8.3.0 /projects/elastic/master/kibana
├─┬ @percy/agent@0.28.6
│ ├── axios@0.21.4
│ └─┬ retry-axios@1.0.1
│   └── axios@0.21.4 deduped
├─┬ @slack/webhook@5.0.4
│ └── axios@0.21.4
├── axios@0.27.2
├─┬ backport@7.3.1
│ └── axios@0.25.0
└─┬ chromedriver@100.0.0
  └── axios@0.24.0

elasticmachine · 2021-09-08T21:55:10Z

Pinging @elastic/kibana-operations (Team:Operations)

jbudz · 2021-09-13T14:16:49Z

@elasticmachine merge upstream

jbudz · 2021-09-13T20:47:33Z

This break is somewhere in the 0.21.2 release. Taking a look at our test interceptors..

jbudz · 2021-09-13T22:08:18Z

Looks similar to https://github.com/axios/axios/pull/3688/files#r706543576

jbudz · 2021-09-13T22:25:27Z

axios/axios#4036

jportner · 2022-01-07T17:31:33Z

@jbudz this comment claims that the problem was fixed in axios@v0.21.3.

Can we resurrect this PR and upgrade/retest? It would be great to get this shipped with the 7.17 release.

elasticmachine · 2022-05-09T16:12:13Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2022-05-09T16:12:13Z

Pinging @elastic/fleet (Team:Fleet)

pjhampton

🌔 🚀 ✨ LGTM ✨ 🚀 🌔

(Sec Telemetry - after comments from @azasypkin are addressed).
I think I would like to move off axios and use node-fetch or something for sec-telemetry. I might refactor this once this has been sorted.

kpollich

Fleet changes LGTM

patrykkopycinski

LGTM

pmuellr

ResponseOps changes LGTM

ThomThomson

Presentation team test syntax change LGTM! Code only review

azasypkin · 2022-05-11T14:31:02Z

@elasticmachine merge upstream

azasypkin · 2022-05-12T08:11:37Z

@elasticmachine merge upstream

kibana-ci · 2022-05-12T09:21:51Z

💛 Build succeeded, but was flaky

Failed CI Steps

APM Cypress Tests

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1089	1094	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1020.1KB	1.0MB	+5.7KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/pm`	52	75	+23

Total ESLint disabled count

id	before	after	diff
`@kbn/pm`	58	81	+23

History

💚 Build #44069 succeeded 6aac7d1
💚 Build #43361 succeeded 43ba93e
💔 Build #43333 failed 9ecedd2
💚 Build #43297 succeeded 5ccea22
💔 Build #43283 failed 4718957
💔 Build #43273 failed 8dbbcd9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

azasypkin · 2022-05-12T09:49:33Z

Since the PR has an absolute majority of the approvals I'm going to merge it now to reduce the risk of conflicts with the upstream.

@parkiino feel free to leave your feedback after the merge if any and I'll handle it separately.

kibanamachine · 2022-05-12T09:53:11Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts You might need to backport the following PRs to 7.17: - [ci-stats-reporter] use a default timeout of 60 seconds (#131428)

Manual backport

To create the backport manually run:

node scripts/backport --pr 111655

Questions ?

Please refer to the Backport tool documentation

…132110) * Upgrade `axios` dependency (`0.21.1` → `0.27.2`). (#111655) Co-authored-by: Aleh Zasypkin <aleh.zasypkin@elastic.co> (cherry picked from commit b191f14) # Conflicts: # packages/kbn-pm/dist/index.js # x-pack/plugins/actions/server/builtin_action_types/servicenow/utils.test.ts # x-pack/plugins/actions/server/builtin_action_types/servicenow/utils.ts # x-pack/plugins/fleet/server/telemetry/sender.ts # x-pack/plugins/osquery/server/lib/telemetry/sender.ts # x-pack/plugins/security_solution/scripts/endpoint/blocklists/index.ts # x-pack/plugins/security_solution/server/lib/telemetry/sender.ts # x-pack/plugins/synthetics/server/lib/telemetry/sender.ts # x-pack/test/performance/services/auth.ts # x-pack/test/ui_capabilities/common/services/ui_capabilities.ts # yarn.lock * Update yarn.lock Co-authored-by: Jonathan Budzenski <jon@elastic.co>

parkiino

looks fine to me. sorry i didn't get to it earlier

jbudz added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.2 labels Sep 8, 2021

jportner approved these changes Sep 8, 2021

View reviewed changes

jbudz requested a review from a team as a code owner September 8, 2021 22:06

jbudz enabled auto-merge (squash) September 8, 2021 22:06

tylersmalley approved these changes Sep 8, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

jbudz disabled auto-merge September 13, 2021 20:46

jbudz removed v7.15.0 v7.14.2 labels Oct 20, 2021

spalger added v7.17.0 and removed v7.16.0 labels Dec 7, 2021

jbudz added 2 commits January 10, 2022 14:39

Bump axios

6867e29

fix types

37a81d8

jbudz force-pushed the bump-axios branch from 28ae99a to 37a81d8 Compare January 10, 2022 20:46

jbudz requested a review from a team as a code owner January 10, 2022 20:46

jbudz marked this pull request as draft January 10, 2022 20:46

build kbn-pm

4391d0a

jbudz added the v8.1.0 label Jan 10, 2022

azasypkin requested a review from a team as a code owner May 9, 2022 16:11

azasypkin requested review from parkiino and pzl May 9, 2022 16:11

pzl approved these changes May 9, 2022

View reviewed changes

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team labels May 9, 2022

azasypkin added v7.17.4 and removed v7.17.2 labels May 9, 2022

pjhampton approved these changes May 9, 2022

View reviewed changes

kpollich approved these changes May 9, 2022

View reviewed changes

patrykkopycinski approved these changes May 9, 2022

View reviewed changes

pmuellr mentioned this pull request May 10, 2022

[ResponseOps][connectors] investigate using http proxy service forwarding to https services #125837

Closed

pmuellr approved these changes May 10, 2022

View reviewed changes

pmuellr mentioned this pull request May 10, 2022

[ResponseOps] POC: switch to use hpagent for proxy #131971

Closed

14 tasks

shahzad31 approved these changes May 11, 2022

View reviewed changes

kpatticha approved these changes May 11, 2022

View reviewed changes

ThomThomson approved these changes May 11, 2022

View reviewed changes

Merge branch 'main' into bump-axios

6aac7d1

Merge branch 'main' into bump-axios

470fecb

azasypkin merged commit b191f14 into elastic:main May 12, 2022

azasypkin mentioned this pull request May 12, 2022

[7.17] Upgrade axios dependency (0.21.1 → 0.27.2). (#111655) #132110

Merged

parkiino reviewed May 12, 2022

View reviewed changes

Conversation

jbudz commented Sep 8, 2021 • edited by azasypkin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Sep 8, 2021

Uh oh!

jbudz commented Sep 13, 2021

Uh oh!

This comment has been minimized.

jbudz commented Sep 13, 2021

Uh oh!

jbudz commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbudz commented Sep 13, 2021

Uh oh!

jportner commented Jan 7, 2022

Uh oh!

elasticmachine commented May 9, 2022

Uh oh!

elasticmachine commented May 9, 2022

Uh oh!

pjhampton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

azasypkin commented May 11, 2022

Uh oh!

azasypkin commented May 12, 2022

Uh oh!

kibana-ci commented May 12, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

azasypkin commented May 12, 2022

Uh oh!

kibanamachine commented May 12, 2022

💔 All backports failed

Manual backport

Questions ?

Uh oh!

parkiino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

jbudz commented Sep 8, 2021 •

edited by azasypkin

Loading

jbudz commented Sep 13, 2021 •

edited

Loading

pjhampton left a comment •

edited

Loading