[TSVB] Fix annotation bounds bug#128242
Merged
flash1293 merged 3 commits intoelastic:mainfrom Mar 24, 2022
Merged
Conversation
flash1293
added
Feature:TSVB
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mbondyra
approved these changes
Mar 24, 2022
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
Tested on Chrome and it is working as expected. Not sure if there are some implications of this change though so hopefully we'll receive an answer from @simianhacker :)
Contributor
Author
|
Going forward with merging this - feel free to reach out later @simianhacker in case we should adjust this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128167
#125222 switched the annotation fetching to use the panel interval. However the annotations request would subtract the length of the interval from the end of the time range which can now cause bounds with a higher min than max in case the configured panel interval is larger than the current time range.
I can't see a reason for changing the provided time range for the request, it's not something we are doing for the data series:
kibana/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/date_histogram.js
Line 52 in efcdbb6
This behavior has been in there from the start - @simianhacker do you still know by any chance what that's related to? I tried to break it somehow without subtracting one interval length from the end of the time range but didn't manage to do so.
4f3e625