[TSVB] Use panel interval for annotations#125222
Merged
flash1293 merged 9 commits intoelastic:mainfrom Feb 14, 2022
Merged
Conversation
flash1293
added
Feature:TSVB
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Feb 14, 2022
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
This makes sense Joe. Changes LGTM. I tested it locally with interval > and < of the auto interval and works as described in the PR!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit 5babc9f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14755
This PR takes the panel interval for the annotation request as well instead of defaulting to "auto" if the panel interval is smaller than the auto interval.
The reason for not taking the panel interval if it's larger than auto is that it would break existing visualizations (existing annotations would appear less precise and annotations could be missing because they are rolled up in a single bucket).
Before:
After:
