Skip to content

delete unused es_archive visualize_embedding#126001

Merged
LeeDr merged 5 commits intoelastic:mainfrom
LeeDr:cleanupVisualize_embedding
Feb 21, 2022
Merged

delete unused es_archive visualize_embedding#126001
LeeDr merged 5 commits intoelastic:mainfrom
LeeDr:cleanupVisualize_embedding

Conversation

@LeeDr
Copy link
Copy Markdown

@LeeDr LeeDr commented Feb 17, 2022 •
edited
Loading

Summary

Running the full ci to check that these es_archives aren't used;

  • test/functional/fixtures/es_archiver/visualize_embedding
  • test/functional/fixtures/es_archiver/mgmt
  • a few more...

Seems some of these were left behind in a large PR that removed timelion

@LeeDr LeeDr added v7.17.1 v8.0.1 v8.1.0 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes test_ui_functional labels Feb 18, 2022
@LeeDr LeeDr marked this pull request as ready for review February 18, 2022 03:20
@LeeDr
Copy link
Copy Markdown
Author

LeeDr commented Feb 18, 2022

@elasticmachine merge upstream

@LeeDr
Copy link
Copy Markdown
Author

LeeDr commented Feb 21, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 21, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm self-requested a review February 21, 2022 18:31
bhavyarm
bhavyarm approved these changes Feb 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr LeeDr merged commit 6c08388 into elastic:main Feb 21, 2022
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2022
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (elastic#126001)
95615c7 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (elastic#126001)
274a641 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2022
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (elastic#126001)
fad9177 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 21, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (#126001) (#126108)
3c9ce4a 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (#126001) (#126107)
59c4a8b 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 21, 2022
@kibanamachine
delete unused es_archive visualize_embedding (#126001) (#126106)
e452e96 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6c08388)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@kibanamachine
delete unused es_archive visualize_embedding (elastic#126001)
4a9e8bd 
* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
academo added a commit that referenced this pull request Mar 3, 2022
@academo @juliaElastic
@kibanamachine @szabosteve @flash1293 @mistic @criamico @azasypkin @MadameSheema @mattkime @ymao1 @jportner
[Cases] Refactor: Move cases action buttons out of timelines (#126265)
83105bd 
* WIP

* WIP2

* Use new cases context hooks to open and close the flyout

* Update timelines to use new hooks

* CLose flyout on create success

* Add back sucess toast

* Move code to a dedicated component

* Add CasesContext to observability

* Remove dependency

* Small refactor

* Use observabilityAppId instead of observabilityFeatureId for buttons

* Add CasesContext to timetable

* Fix detection engine test cases

* Fix broken tests

* Fix broken tests

* Rename hook

* Add test cases for cases context ui

* Add test for new hook

* Remove state from the provider context

* Remove basevalue

* apply suggested renaming

* Add usecallback

* Add reducer types, fix test type, remove redundant check

* Accept attachments as a prop for the cases select modal

* Expose useCasesAddToExistingCase hook, reducer code and global component

* use the new hook to open the select cases modasl

* Fix tests and types

* Add tests for cases global components

* [Fleet] showing agent policy creation error message on UI (#125931)

* showing agent policy creation error message on UI

* mapping the error instead of showing from the backend

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [ResponseOps] Adds tooltip to time window selector in ES query rule flyout (#125764)

* [Lens] Allow detaching from global time range (#125563)

* allow detaching from global time range

* add test

* fix time field recognition

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Fleet] refactor auto upgrade package policies logic (#125909)

* refactor upgrade package policies

* fixed tests

* code cleanup

* review improvements

* added api test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* skip flaky suite (#126027)

* Remove deprecated api (#125524)

* [Fleet] Remove deprecated kibana APIs - License

* Remove basePath from FleetApp

* Replace AsyncPlugin with Plugin

* Get fieldFormats from fieldFormats plugin rather than data plugin

* Fix ts errors

* Attempt fixing wrong type

* Move licenseService to FleetStartDeps

* Fix types and mocks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Upgrade `markdown-it` dependency (`10.0.0` → `12.3.2`). (#125526)

* skipping failing tests (#126039)

* remove unused deprecated code and use field format plugin directly for data view field editor (#126029)

* [data views] Improve preview pane (#126013)

* fix preview pane

* fix preview pane

* one less span tag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Alerting] Provide services to set context for recovered alerts (#124972)

* Rename alert instance to alert and add create fn to alert factory

* Rename alert instance to alert and add create fn to alert factory

* Fixing types

* Fixing types

* Adding flag for rule types to opt into setting recovery context

* Only showing context in action variable menu if flag set to true

* Adding recovery functions to createAlertFactory

* Setting recovery in index threshold and fixing types

* Fixing lint issues and some refactoring

* Cleanup

* Functional tests for index threshold rule recovery context

* Return array of recovered alerts instead of record

* Fixing types

* Fixing types

* Cleanup

* Handling nulls and more tests

* Updating developer docs

* Making getRecoveryAlerts non-optional

* Setting unknown in index threshold recovery value

* PR feedback

* Adding a test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Discover] Re-introduce saved_searches test (#126059)

* [Archive Migration]  index pattern without timefield (#125870)

* kbn_archive date_nanos

* kbn_archive date_nanos in context and discover

* kbn_archiver more date_nanos tests

* split out kbnArchiver for index_pattern_without_timefield

* remove date_nanos files from a different PR

* update another test for usage of the same archives

* set default index pattern for test

* remove duplicate const kibanaServer

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* delete unused es_archive visualize_embedding (#126001)

* delete unused es_archive

* remove other unused es_archive

* more unused es_archives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Bump packages (#126119)

* url-parse 1.5.3 -> 1.5.9
* follow-redirects 1.y.z -> 1.14.9

* Add tests for all cases selector and attachments

* Add tests for use add to existing case hook

* First version of the cases timeline actions

* export add alert to new case button from cases plugin

* Make Cases ECS compatible with timelines and security_solution

* Delete new case button

* Add helpers

* Use the cases hook directly for add to new case

* Remov unused dependencies

* Rename callbacks, remove timelines calls

* Fixing tests for the dropdown

* Fix broken test

* mocking cases for tests

* Fix detectiosn tests

* Observability now uses the new cases hooks

* Wrap events viewer into cases context

* Open the create case flyout if create case was selected in the modal

* Fix cases mocks for security_solution

* Update tests

* Add tests for use cases toast

* Improve cases mock

* delete security mock

* replace tests mocks for cases

* fix import mock

* Do not require onRowClick

* Show the toast inside the modal

* show the toast inside the flyout

* remove toast logic from the consumer plugin

* fix typescript types

* Rename type

* Fix broken test

* Fix file name and broken test

* Use internal navigation hook

* Update hook dependencies

* Move useCaseToast

* Fix mock paths

* fix eslint

* Add test cases for the toast content

* Add cases context to the overview page

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@elastic.co>
Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Co-authored-by: Matthew Kime <matt@mattki.me>
Co-authored-by: Ying Mao <ying.mao@elastic.co>
Co-authored-by: Maja Grubic <maja.grubic@elastic.co>
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.17.1 v8.0.1 v8.1.0 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeeDr @kibana-ci @kibanamachine @bhavyarm