[Archive Migration] index pattern without timefield by LeeDr · Pull Request #125870 · elastic/kibana

LeeDr · 2022-02-16T20:50:12Z

Summary

test/functional/fixtures/es_archiver/index_pattern_without_timefield/data.json had both data and kibana indices combined so this PR splits the kibana saved objects out to a kbn_archive.

Part of: #102552

LeeDr · 2022-02-17T15:26:31Z

x-pack/test/functional/apps/discover/value_suggestions_non_timebased.ts

+      await kibanaServer.importExport.load(
+        'test/functional/fixtures/kbn_archiver/index_pattern_without_timefield'
+      );
+      await kibanaServer.uiSettings.replace({ defaultIndex: 'without-timefield' });


As you can see in test/functional/fixtures/kbn_archiver/index_pattern_without_timefield.json there are actually two index patterns in that archive with-timefield and without-timefield. The previous test runs failed because the with-timefield index pattern ended up being the default one in Discover. I added code here to set the default to the one the test needs (it's faster than having the test select it in the UI).

LeeDr · 2022-02-17T16:09:33Z

I don't think this failure was related..

│1)    rule registry spaces only: trial
  | │       Rule Registry API
  | │         with write permissions
  | │           when creating a rule
  | │             writes alerts data to the alert indices:
  | │
  | │
  | │       Error: expected 'active' to sort of equal 'recovered'
  | │       + expected - actual

LeeDr · 2022-02-17T20:51:47Z

@elasticmachine merge upstream

kibanamachine · 2022-02-17T20:51:48Z

merge conflict between base and head

elasticmachine · 2022-02-17T23:10:52Z

Pinging @elastic/kibana-qa (Team:QA)

LeeDr · 2022-02-18T17:37:49Z

@elasticmachine merge upstream

kertal

LGTM 👍 , DataDiscover.team code review

LeeDr · 2022-02-21T16:08:59Z

@elasticmachine merge upstream

kibana-ci · 2022-02-21T17:38:04Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #25180 succeeded 35c16fc
💚 Build #25126 succeeded 30bcf60
💔 Build #25120 failed b77cc66
💔 Build #24993 failed 0203ae8
💔 Build #24848 failed 0d4da1f
💔 Build #24827 failed c6cb706

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2022-02-21T18:31:51Z

💔 All backports failed

Status	Branch	Result
❌	8.1	Backport failed because of merge conflicts
❌	8.0	Backport failed because of merge conflicts
❌	7.17	Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 125870

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2022-02-23T18:36:27Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-02-24T18:46:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

* kbn_archive date_nanos * kbn_archive date_nanos in context and discover * kbn_archiver more date_nanos tests * split out kbnArchiver for index_pattern_without_timefield * remove date_nanos files from a different PR * update another test for usage of the same archives * set default index pattern for test * remove duplicate const kibanaServer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* WIP * WIP2 * Use new cases context hooks to open and close the flyout * Update timelines to use new hooks * CLose flyout on create success * Add back sucess toast * Move code to a dedicated component * Add CasesContext to observability * Remove dependency * Small refactor * Use observabilityAppId instead of observabilityFeatureId for buttons * Add CasesContext to timetable * Fix detection engine test cases * Fix broken tests * Fix broken tests * Rename hook * Add test cases for cases context ui * Add test for new hook * Remove state from the provider context * Remove basevalue * apply suggested renaming * Add usecallback * Add reducer types, fix test type, remove redundant check * Accept attachments as a prop for the cases select modal * Expose useCasesAddToExistingCase hook, reducer code and global component * use the new hook to open the select cases modasl * Fix tests and types * Add tests for cases global components * [Fleet] showing agent policy creation error message on UI (#125931) * showing agent policy creation error message on UI * mapping the error instead of showing from the backend Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [ResponseOps] Adds tooltip to time window selector in ES query rule flyout (#125764) * [Lens] Allow detaching from global time range (#125563) * allow detaching from global time range * add test * fix time field recognition * fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Fleet] refactor auto upgrade package policies logic (#125909) * refactor upgrade package policies * fixed tests * code cleanup * review improvements * added api test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * skip flaky suite (#126027) * Remove deprecated api (#125524) * [Fleet] Remove deprecated kibana APIs - License * Remove basePath from FleetApp * Replace AsyncPlugin with Plugin * Get fieldFormats from fieldFormats plugin rather than data plugin * Fix ts errors * Attempt fixing wrong type * Move licenseService to FleetStartDeps * Fix types and mocks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Upgrade `markdown-it` dependency (`10.0.0` → `12.3.2`). (#125526) * skipping failing tests (#126039) * remove unused deprecated code and use field format plugin directly for data view field editor (#126029) * [data views] Improve preview pane (#126013) * fix preview pane * fix preview pane * one less span tag Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Alerting] Provide services to set context for recovered alerts (#124972) * Rename alert instance to alert and add create fn to alert factory * Rename alert instance to alert and add create fn to alert factory * Fixing types * Fixing types * Adding flag for rule types to opt into setting recovery context * Only showing context in action variable menu if flag set to true * Adding recovery functions to createAlertFactory * Setting recovery in index threshold and fixing types * Fixing lint issues and some refactoring * Cleanup * Functional tests for index threshold rule recovery context * Return array of recovered alerts instead of record * Fixing types * Fixing types * Cleanup * Handling nulls and more tests * Updating developer docs * Making getRecoveryAlerts non-optional * Setting unknown in index threshold recovery value * PR feedback * Adding a test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Discover] Re-introduce saved_searches test (#126059) * [Archive Migration] index pattern without timefield (#125870) * kbn_archive date_nanos * kbn_archive date_nanos in context and discover * kbn_archiver more date_nanos tests * split out kbnArchiver for index_pattern_without_timefield * remove date_nanos files from a different PR * update another test for usage of the same archives * set default index pattern for test * remove duplicate const kibanaServer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * delete unused es_archive visualize_embedding (#126001) * delete unused es_archive * remove other unused es_archive * more unused es_archives Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Bump packages (#126119) * url-parse 1.5.3 -> 1.5.9 * follow-redirects 1.y.z -> 1.14.9 * Add tests for all cases selector and attachments * Add tests for use add to existing case hook * First version of the cases timeline actions * export add alert to new case button from cases plugin * Make Cases ECS compatible with timelines and security_solution * Delete new case button * Add helpers * Use the cases hook directly for add to new case * Remov unused dependencies * Rename callbacks, remove timelines calls * Fixing tests for the dropdown * Fix broken test * mocking cases for tests * Fix detectiosn tests * Observability now uses the new cases hooks * Wrap events viewer into cases context * Open the create case flyout if create case was selected in the modal * Fix cases mocks for security_solution * Update tests * Add tests for use cases toast * Improve cases mock * delete security mock * replace tests mocks for cases * fix import mock * Do not require onRowClick * Show the toast inside the modal * show the toast inside the flyout * remove toast logic from the consumer plugin * fix typescript types * Rename type * Fix broken test * Fix file name and broken test * Use internal navigation hook * Update hook dependencies * Move useCaseToast * Fix mock paths * fix eslint * Add test cases for the toast content * Add cases context to the overview page Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@elastic.co> Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co> Co-authored-by: Matthew Kime <matt@mattki.me> Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: Maja Grubic <maja.grubic@elastic.co> Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Lee Drengenberg added 5 commits February 16, 2022 12:43

kbn_archive date_nanos

35511c1

kbn_archive date_nanos in context and discover

9986bb6

kbn_archiver more date_nanos tests

afb53ab

split out kbnArchiver for index_pattern_without_timefield

a82bc27

remove date_nanos files from a different PR

c6cb706

LeeDr changed the title ~~Kbn archiverindex pattern without timefield~~ [Archive Migration] index pattern without timefield Feb 16, 2022

LeeDr added v7.17.1 v8.0.1 v8.1.0 v8.2.0 Feature:Functional Testing test_ui_functional auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// labels Feb 16, 2022

update another test for usage of the same archives

0d4da1f

LeeDr mentioned this pull request Feb 16, 2022

[meta] Migrate .kibana esArchives to kbnArchiver #102552

Closed

set default index pattern for test

0203ae8

LeeDr commented Feb 17, 2022

View reviewed changes

Lee Drengenberg added 2 commits February 17, 2022 14:55

merge

b77cc66

remove duplicate const kibanaServer

30bcf60

LeeDr marked this pull request as ready for review February 17, 2022 23:10

LeeDr requested a review from a team as a code owner February 17, 2022 23:10

Merge branch 'main' into kbnArchiverindex_pattern_without_timefield

35c16fc

kertal approved these changes Feb 21, 2022

View reviewed changes

Merge branch 'main' into kbnArchiverindex_pattern_without_timefield

c13acea

LeeDr merged commit 3907724 into elastic:main Feb 21, 2022

This was referenced Feb 22, 2022

[8.1] [Archive Migration] index pattern without timefield (#125870) #126177

Merged

[8.0] [Archive Migration] index pattern without timefield (#125870) #126178

Merged

[7.17] [Archive Migration] index pattern without timefield (#125870) #126179

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 23, 2022

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2022

LeeDr mentioned this pull request Jun 6, 2022

remove kibana saved object from the esArchive #133674

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Archive Migration] index pattern without timefield#125870

[Archive Migration] index pattern without timefield#125870
LeeDr merged 11 commits intoelastic:mainfrom
LeeDr:kbnArchiverindex_pattern_without_timefield

LeeDr commented Feb 16, 2022 •

edited

Loading

Uh oh!

LeeDr Feb 17, 2022 •

edited

Loading

Uh oh!

LeeDr commented Feb 17, 2022

Uh oh!

LeeDr commented Feb 17, 2022

Uh oh!

kibanamachine commented Feb 17, 2022

Uh oh!

elasticmachine commented Feb 17, 2022

Uh oh!

LeeDr commented Feb 18, 2022

Uh oh!

kertal left a comment

Uh oh!

LeeDr commented Feb 21, 2022

Uh oh!

kibana-ci commented Feb 21, 2022

Uh oh!

kibanamachine commented Feb 21, 2022

Uh oh!

kibanamachine commented Feb 23, 2022

Uh oh!

kibanamachine commented Feb 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LeeDr commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

LeeDr Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LeeDr commented Feb 17, 2022

Uh oh!

LeeDr commented Feb 17, 2022

Uh oh!

kibanamachine commented Feb 17, 2022

Uh oh!

elasticmachine commented Feb 17, 2022

Uh oh!

LeeDr commented Feb 18, 2022

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr commented Feb 21, 2022

Uh oh!

kibana-ci commented Feb 21, 2022

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Feb 21, 2022

💔 All backports failed

How to fix

Questions ?

Uh oh!

kibanamachine commented Feb 23, 2022

Uh oh!

kibanamachine commented Feb 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LeeDr commented Feb 16, 2022 •

edited

Loading

LeeDr Feb 17, 2022 •

edited

Loading