Skip to content

[Fleet] revert package policy validation that caused issue with input groups #125657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliaElastic merged 1 commit into from
Feb 15, 2022
Merged

[Fleet] revert package policy validation that caused issue with input groups #125657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion x-pack/plugins/fleet/common/services/validate_package_policy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,8 @@ describe('Fleet - validatePackagePolicy()', () => {
});
});

it('returns package policy validation error if input var does not exist', () => {
// TODO enable when https://github.com/elastic/kibana/issues/125655 is fixed
it.skip('returns package policy validation error if input var does not exist', () => {
expect(
validatePackagePolicy(
{
Expand Down
14 changes: 5 additions & 9 deletions x-pack/plugins/fleet/common/services/validate_package_policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,15 +210,11 @@ export const validatePackagePolicyConfig = (
}

if (varDef === undefined) {
errors.push(
i18n.translate('xpack.fleet.packagePolicyValidation.nonExistentVarMessage', {
defaultMessage: '{varName} var definition does not exist',
values: {
varName,
},
})
);
return errors;
// TODO return validation error here once https://github.com/elastic/kibana/issues/125655 is fixed
// eslint-disable-next-line no-console
console.debug(`No variable definition for ${varName} found`);

return null;
}

if (varDef.required) {
Expand Down