[Fleet] revert package policy validation that caused issue with input groups#125657
Merged
juliaElastic merged 1 commit intoelastic:mainfrom Feb 15, 2022
Merged
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build SucceededMetrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2022
…lastic#125657) (cherry picked from commit 35f4ba5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2022
…lastic#125657) (cherry picked from commit 35f4ba5)
Contributor
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 15, 2022
kibanamachine
added a commit
that referenced
this pull request
Feb 15, 2022
kpollich
pushed a commit
to kpollich/kibana
that referenced
this pull request
Jul 13, 2022
…lastic#125657) (cherry picked from commit 35f4ba5) # Conflicts: # x-pack/plugins/fleet/common/services/validate_package_policy.test.ts
kpollich
added a commit
that referenced
this pull request
Jul 14, 2022
…groups (#125657) (#136338) * revert package policy validation that caused issue with input groups (#125657) (cherry picked from commit 35f4ba5) # Conflicts: # x-pack/plugins/fleet/common/services/validate_package_policy.test.ts * Skip test Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially revert #124215 to unblock #125625
Improvement of validation is raised here #125655
To summarize:
Aws package policy generated by elastic-package is rejected with validation errors, however it should be accepted.
The reason is that policy vars present in package definition global vars, are listed under inputs/streams.
This should be accepted according to this: #125625 (comment)
Example package policy that should be valid, see below.
To verify, run this with a valid agent policy id in
policy_id, and verify that it is successfully created.