[7.17] Fixes missing border in kql bar in Firefox#123990
Merged
Conversation
snide
added
release_note:skip
snide
commented
Jan 28, 2022
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Jan 28, 2022
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
LGTM! 👍 tested a-la-carte, compared to a 7.16.3 instance, border is displayed now. Welcome back Dave, we missed you, can I assign you some more issues 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem does not exist on main, only on late-era 7.x versions of Kibana. Firefox applies a 1 pixel margin to the top/bottom of textareas. This causes it to go from 38->40 pixels in total box size, and will expand 2px beyond it's containers overflow.
@spenceralger made the fix in for main when we switched up the themes. This small bit just needs to exist in the old code as well. #113570
hat tip to @mfinkle, the forever firefox user who spotted the issue.
BEFORE
AFTER