remove all references to v7 theme#113570
Merged
spalger merged 6 commits intoelastic:mainfrom Oct 29, 2021
Merged
Conversation
spalger
force-pushed
the
remove/v7-theme
branch
3 times, most recently
from
d406e9e to
ea853bc
Compare
spalger
force-pushed
the
remove/v7-theme
branch
from
61b96cc to
059287f
Compare
spalger
force-pushed
the
remove/v7-theme
branch
from
0ac7378 to
c4e6d40
Compare
This comment has been minimized.
This comment has been minimized.
6 tasks
spalger
force-pushed
the
remove/v7-theme
branch
from
c4e6d40 to
47fd419
Compare
cchaos
reviewed
Oct 25, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks so much for getting this PR up! I wasn't even expecting you to take care of all the Sass and font stuff too, so thank you!!
spalger
force-pushed
the
remove/v7-theme
branch
3 times, most recently
from
78171be to
ed7711c
Compare
cchaos
approved these changes
Oct 26, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
🙌 LGTM! Thanks so much for all this work!!!!
spalger
force-pushed
the
remove/v7-theme
branch
from
ed7711c to
2bdd108
Compare
spalger
added
release_note:skip
spalger
force-pushed
the
remove/v7-theme
branch
from
ebd9a5f to
4d226c6
Compare
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jportner
approved these changes
Oct 28, 2021
jbudz
approved these changes
Oct 28, 2021
pgayvallet
reviewed
Oct 28, 2021
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
see comment about adding a migration for the setting's value
cchaos
approved these changes
Oct 28, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
👍 Big approval from design!
poffdeluxe
approved these changes
Oct 29, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 29, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/presentation_util/public/components/solution_toolbar/items/quick_group.scss
spalger
pushed a commit
that referenced
this pull request
Nov 1, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/presentation_util/public/components/solution_toolbar/items/quick_group.scss Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116155
Its past time to remove the v7 theme from the product, this takes care or removing all traces.