Skip to content

Comments

[7.16] [Infra UI] Avoid eager async imports in metric alert registrations (#123285)#123967

Merged
weltenwort merged 2 commits intoelastic:7.16from
weltenwort:backport/7.16/pr-123285
Jan 31, 2022
Merged

[7.16] [Infra UI] Avoid eager async imports in metric alert registrations (#123285)#123967
weltenwort merged 2 commits intoelastic:7.16from
weltenwort:backport/7.16/pr-123285

Conversation

@weltenwort
Copy link
Member

@weltenwort weltenwort commented Jan 27, 2022

Backports the following commits to 7.16:

ℹ️ Due to the significant amount of conflicts, this is a more focused subset of the changes made in original PR.

…lastic#123285)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@weltenwort weltenwort added the backport This PR is a backport of another PR label Jan 27, 2022
@weltenwort weltenwort enabled auto-merge (squash) January 27, 2022 18:52
@weltenwort weltenwort disabled auto-merge January 27, 2022 18:53
@weltenwort weltenwort changed the title [7.16] [Infra UI] Avoid eager async imports in metric alert registrations (#123285) [Infra UI] Avoid eager async imports in metric alert registrations (#123285) Jan 27, 2022
@weltenwort weltenwort changed the title [Infra UI] Avoid eager async imports in metric alert registrations (#123285) [7.16] [Infra UI] Avoid eager async imports in metric alert registrations (#123285) Jan 31, 2022
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1003.5KB 940.1KB -63.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 62.1KB 89.3KB +27.2KB
Unknown metric groups

async chunk count

id before after diff
infra 14 13 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort merged commit 10eca1c into elastic:7.16 Jan 31, 2022
@weltenwort weltenwort deleted the backport/7.16/pr-123285 branch January 31, 2022 20:13
@weltenwort weltenwort self-assigned this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants