[Infra UI] Avoid eager async imports in metric alert registrations by weltenwort · Pull Request #123285 · elastic/kibana

weltenwort · 2022-01-18T19:01:52Z

📝 Summary

This reverts the eager async imports introduced in #119557 to make sure most chunks are loaded on-demand. In doing so it untangles a web of forbidden imports across the public and server directories which were flagged as linter exceptions.

closes #122941

🕵️‍♀️ Review notes

There seems to have been quite some duplication between types in the server and common, so most forbidden imports could be removed by importing from common instead. Where the type didn't yet exist in common, this moves it there.
The core of this PR is to make sure no infra.chunk.N.js bundles are loaded on the login screen, but keep the rule creation fly-outs working.

elasticmachine · 2022-01-19T13:25:05Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

weltenwort · 2022-01-25T13:09:57Z

looks like an unrelated failure of the CI infrastructure

weltenwort · 2022-01-25T13:10:08Z

@elasticmachine merge upstream

kibana-ci · 2022-01-25T14:29:20Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	923	920	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	997.4KB	926.6KB	-70.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	62.2KB	90.5KB	+28.3KB

Unknown metric groups

async chunk count

id	before	after	diff
`infra`	14	13	-1

ESLint disabled line counts

id	before	after	diff
`infra`	151	127	-24

Total ESLint disabled count

id	before	after	diff
`infra`	158	134	-24

History

💔 Build #19339 failed 7d5bb90
💔 Build #19149 failed af7b981
💚 Build #18360 succeeded cf07c2a
💚 Build #18179 succeeded cce4394
💔 Build #18152 failed e4615a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

weltenwort · 2022-01-25T19:49:25Z

To put the bundle size changes into perspective, here are the changes from the original PR that caused the unfortunate loading behavior:

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	928.7KB	991.0KB	+62.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	88.3KB	62.2KB	-26.1KB

Kerry350 · 2022-01-26T14:39:44Z

Sorry for the delay on this.

Functionally everything looks good.

Before:

After:

Just looking through the code now.

Kerry350

Thank you for untangling all of this ♥️

This cuts a good number of the import changes needed for #58002 (the last issue for #58003).

kibanamachine · 2022-01-26T15:33:51Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts
❌	7.16	Backport failed because of merge conflicts You might need to backport the following PRs to 7.16: - [Metrics UI] Fix OR logic on redundant groupBy detection (#116695)
❌	8.0	Backport failed because of merge conflicts You might need to backport the following PRs to 8.0: - Revert "[Metrics UI] Fix OR logic on redundant groupBy detection (#116695)" (#116820) - [Metrics UI] Fix OR logic on redundant groupBy detection (#116695) - [Metrics UI] Add inventory alert preview (#68909)

How to fix

Re-run the backport manually:

node scripts/backport --pr 123285

Questions ?

Please refer to the Backport tool documentation

weltenwort · 2022-01-26T18:52:45Z

These manual backports will take a while because many of the prior code changes have not been backported cleanly and/or were partially reverted.

…lastic#123285) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 629c602) # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_rule.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_rule_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts

…123285) (#123868) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 629c602) # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_rule.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_rule_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts

…lastic#123285) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 629c602) # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/expression_chart.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/inventory/index.ts # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/index.ts # x-pack/plugins/infra/public/plugin.ts # x-pack/plugins/infra/server/features.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_anomaly/metric_anomaly_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts # x-pack/test/api_integration/apis/metrics_ui/metric_threshold_alert.ts

…lastic#123285) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…ions (#123285) (#123967) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…lastic#123285) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/expression_chart.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/inventory/index.ts # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/index.ts # x-pack/plugins/infra/public/plugin.ts # x-pack/plugins/infra/server/features.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_anomaly/metric_anomaly_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts # x-pack/test/api_integration/apis/metrics_ui/metric_threshold_alert.ts

…123285) (#124177) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/expression_chart.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/inventory/index.ts # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/index.ts # x-pack/plugins/infra/public/plugin.ts # x-pack/plugins/infra/server/features.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_anomaly/metric_anomaly_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts # x-pack/test/api_integration/apis/metrics_ui/metric_threshold_alert.ts

weltenwort added 3 commits January 18, 2022 18:20

Remove invalid imports across public/server

c5030e2

Redirect more forbidden imports

51bb210

Fix imports broken due to deleted intermediate files

17d5f47

weltenwort self-assigned this Jan 18, 2022

weltenwort added 4 commits January 18, 2022 19:10

Invert import direction to invert chunk dependency

a447341

Deduplicate invalid query symbol

e4615a4

Fix imports in api integration tests

cce4394

Merge branch 'main' into infra-ui-fix-lazy-public-imports

cf07c2a

weltenwort marked this pull request as ready for review January 19, 2022 13:25

weltenwort requested a review from a team as a code owner January 19, 2022 13:25

Merge branch 'main' into infra-ui-fix-lazy-public-imports

af7b981

Kerry350 self-requested a review January 25, 2022 10:17

weltenwort added 2 commits January 25, 2022 10:48

Merge branch 'main' into infra-ui-fix-lazy-public-imports

c7414c7

Fix newly added import

7d5bb90

Merge branch 'main' into infra-ui-fix-lazy-public-imports

382ac4a

Kerry350 approved these changes Jan 26, 2022

View reviewed changes

weltenwort merged commit 629c602 into elastic:main Jan 26, 2022

weltenwort deleted the infra-ui-fix-lazy-public-imports branch January 26, 2022 15:30

weltenwort mentioned this pull request Jan 26, 2022

[8.0] [Infra UI] Avoid eager async imports in metric alert registrations (#123285) #123868

Merged

weltenwort mentioned this pull request Jan 27, 2022

[Infra UI] Avoid eager async imports in metric alert registrations (#123285) #123952

Closed

weltenwort mentioned this pull request Jan 27, 2022

[7.16] [Infra UI] Avoid eager async imports in metric alert registrations (#123285) #123967

Merged

weltenwort added a commit that referenced this pull request Jan 31, 2022

[7.16] [Infra UI] Avoid eager async imports in metric alert registrat…

10eca1c

…ions (#123285) (#123967) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

weltenwort mentioned this pull request Jan 31, 2022

[7.17] [Infra UI] Avoid eager async imports in metric alert registrations (#123285) #124177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[Infra UI] Avoid eager async imports in metric alert registrations#123285

[Infra UI] Avoid eager async imports in metric alert registrations#123285
weltenwort merged 11 commits intoelastic:mainfrom
weltenwort:infra-ui-fix-lazy-public-imports

weltenwort commented Jan 18, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Jan 19, 2022

Uh oh!

weltenwort commented Jan 25, 2022

Uh oh!

weltenwort commented Jan 25, 2022

Uh oh!

kibana-ci commented Jan 25, 2022

async chunk count

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

weltenwort commented Jan 25, 2022 •

edited

Loading

Uh oh!

Kerry350 commented Jan 26, 2022

Uh oh!

Kerry350 left a comment

Uh oh!

kibanamachine commented Jan 26, 2022

Uh oh!

weltenwort commented Jan 26, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

weltenwort commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🕵️‍♀️ Review notes

Uh oh!

elasticmachine commented Jan 19, 2022

Uh oh!

weltenwort commented Jan 25, 2022

Uh oh!

weltenwort commented Jan 25, 2022

Uh oh!

kibana-ci commented Jan 25, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

weltenwort commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Async chunks

Page load bundle

Uh oh!

Kerry350 commented Jan 26, 2022

Uh oh!

Kerry350 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 26, 2022

💔 All backports failed

How to fix

Questions ?

Uh oh!

weltenwort commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weltenwort commented Jan 18, 2022 •

edited

Loading

weltenwort commented Jan 25, 2022 •

edited

Loading

weltenwort commented Jan 26, 2022 •

edited

Loading