[charts] Fix timezone regression in charts#123478
Merged
markov00 merged 1 commit intoelastic:8.0from Jan 21, 2022
Merged
Conversation
markov00
added
bug
markov00
requested review from
alvarezmelissa87,
cauemarcondes,
qn895,
shahzad31 and
smith
and removed request for
shahzad31
Member
|
ML changes LGTM 🎉 |
qn895
approved these changes
Jan 20, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
brianseeders
added a commit
that referenced
this pull request
Jan 21, 2022
This reverts commit 3e3b0f7.
Contributor
Contributor
|
It likely conflicted because of #123470, which makes a very similar change to the Uptime Duration series and was merged around the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We introduced a regression that causes time series charts without a
timezoneconfigured to be rendered withUTCby default instead of thelocaltimezone.We already have fixed the bug in charts here and the dependency is updated already in versions 7.17, 8.0.1, 8.1 but we are missing
8.0since we are really close to the next RC.This PR brings back the default behavior marking all time-series with no
timezoneparameter using thelocaltimezone.I will forward these changes to
7.17,8.1,mainin a different PR to land this PR sooner as it has a higher priority