Skip to content

[Uptime] Make duration line series use local for time zone value#123470

Merged
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:123466/fix-duration-chart-time-zone-error
Jan 20, 2022
Merged

[Uptime] Make duration line series use local for time zone value#123470
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:123466/fix-duration-chart-time-zone-error

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

Summary

Resolves #123466.

As part of a recent version upgrade for Elastic Charts, we missed that the time zone value for the duration series on the Uptime detail page no longer displays values in accordance with the rest of the plugin.

This patch will fix the disparity.

Testing this PR

The results of this patch are easily observable. See the linked issue for detailed repro steps.

Before

image

After

image

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.17.0 v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Uptime] Duration chart time zone is no longer working

6 participants