[maps] allow feature editing with vector tile scaling#123409
[maps] allow feature editing with vector tile scaling#123409nreese merged 4 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
nickpeihl
left a comment
There was a problem hiding this comment.
The user experience of editing features with vector tile scaling is a little off. Editing features causes the tile URL to change. This results in the entire source being removed from the map and then a new source appearing. This is a little jarring as drawing a feature results in all features being removed for a split second and then all features plus the new feature coming back. I still think its better than making users change scaling to edit features. Thoughts?
I think the benefits of this feature outweigh the UI refresh. We should remove the friction for users as much as possible.
lgtm!
code review and tested in chrome.
Fixes #122049
This PR allows for feature editing when using vector tile scaling. Why? well, asking users to set various layer configurations to enable feature editing is a pain and puts up a barrier to usage. Why would we expect users to change scaling, edit features, and then change scaling back?
The user experience of editing features with vector tile scaling is a little off. Editing features causes the tile URL to change. This results in the entire source being removed from the map and then a new source appearing. This is a little jarring as drawing a feature results in all features being removed for a split second and then all features plus the new feature coming back. I still think its better than making users change scaling to edit features. Thoughts?