Skip to content

[maps] allow feature editing with vector tile scaling#123409

Merged
nreese merged 4 commits intoelastic:mainfrom
nreese:issue_122049
Feb 1, 2022
Merged

[maps] allow feature editing with vector tile scaling#123409
nreese merged 4 commits intoelastic:mainfrom
nreese:issue_122049

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jan 19, 2022

Fixes #122049

This PR allows for feature editing when using vector tile scaling. Why? well, asking users to set various layer configurations to enable feature editing is a pain and puts up a barrier to usage. Why would we expect users to change scaling, edit features, and then change scaling back?

The user experience of editing features with vector tile scaling is a little off. Editing features causes the tile URL to change. This results in the entire source being removed from the map and then a new source appearing. This is a little jarring as drawing a feature results in all features being removed for a split second and then all features plus the new feature coming back. I still think its better than making users change scaling to edit features. Thoughts?

@nreese nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This PR does not require backporting v8.1.0 labels Jan 19, 2022
@nreese nreese requested a review from nickpeihl January 19, 2022 21:00
@nreese nreese requested a review from a team as a code owner January 19, 2022 21:00
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Jan 28, 2022

@elasticmachine merge upstream

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Jan 31, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +103.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user experience of editing features with vector tile scaling is a little off. Editing features causes the tile URL to change. This results in the entire source being removed from the map and then a new source appearing. This is a little jarring as drawing a feature results in all features being removed for a split second and then all features plus the new feature coming back. I still think its better than making users change scaling to edit features. Thoughts?

I think the benefits of this feature outweigh the UI refresh. We should remove the friction for users as much as possible.

lgtm!

code review and tested in chrome.

@nreese nreese merged commit 111b830 into elastic:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] The "edit features" action should always show

5 participants