[Maps] drawing layer documentation by nreese · Pull Request #123373 · elastic/kibana

nreese · 2022-01-19T15:17:02Z

Fixes #108730

PR adds drawing layer documentation. The documentation is in Import geospatial data page.

docs preview

elasticmachine · 2022-01-19T15:17:06Z

Pinging @elastic/kibana-gis (Team:Geo)

elasticmachine · 2022-01-19T15:17:06Z

Pinging @elastic/kibana-docs (Team:Docs)

gchaps

A few minor comments.

docs/maps/import-geospatial-data.asciidoc

gchaps · 2022-01-20T18:30:31Z

docs/maps/import-geospatial-data.asciidoc

+
+. Click layer name in legend and select *Edit features*.
+
+When feature editing is open, a feature editing toolbox is displayed on the left side of the map.


Suggested change

When feature editing is open, a feature editing toolbox is displayed on the left side of the map.

A feature editing toolbox appears on the left side of the map.

Suggest indenting this sentence and the image under step 9. To do this, add a "+" in the empty line.

This sentence and image apply to both "To create a new index for drawing" and "To open an existing index for drawing" set of instructions. For this reason, I did not indent the sentence and image under step 9.

docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

nreese · 2022-01-23T14:11:36Z

@elasticmachine merge upstream

nreese · 2022-01-28T16:51:23Z

@elasticmachine merge upstream

gchaps

A few comments.

docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

kibana-ci · 2022-01-31T13:36:05Z

💚 Build Succeeded

Buildkite Build
Commit: e903d39

History

💚 Build #20727 succeeded a0ae4ff
💚 Build #20450 succeeded ba38f84
💚 Build #18962 succeeded 2635980
💚 Build #18961 succeeded 9d1838c
💚 Build #18960 succeeded 3c576c2
💚 Build #18959 succeeded 3a369f0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gchaps · 2022-01-31T19:46:53Z

latest changes LGTM

nickpeihl

a couple of nits, but lgtm!

thanks for documenting this!

docs/maps/import-geospatial-data.asciidoc

nickpeihl · 2022-01-31T21:52:25Z

docs/maps/import-geospatial-data.asciidoc

+
+. Click *Add layer*.
+
+. Set *Scaling* to *Limit results to 10,000*.


Hopefully we can remove this when #123409 is merged.

correct, along with #124061, the goal is to remove all of these constraints an allow any vector layer with documents source to allow feature editing.

* [Maps] drawing layer documentation * fix formatting * more formating fixes * text changes * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fix formatting of nested bullet Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b6a0a23)

kibanamachine · 2022-02-01T14:11:33Z

💚 All backports created successfully

Status	Branch	Result
✅	8.0
✅	7.14
✅	7.15
✅	7.16
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* [Maps] drawing layer documentation * fix formatting * more formating fixes * text changes * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fix formatting of nested bullet Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b6a0a23) Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

* [Maps] drawing layer documentation (#123373) * [Maps] drawing layer documentation * fix formatting * more formating fixes * text changes * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fix formatting of nested bullet Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b6a0a23) * replace data view with index pattern Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

[Maps] drawing layer documentation

39971b5

nreese added Team:Docs Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v8.1.0 v7.17.0 labels Jan 19, 2022

nreese requested review from gchaps and nickpeihl January 19, 2022 15:17

nreese added 3 commits January 19, 2022 10:52

fix formatting

f615ee5

more formating fixes

9aa40dd

text changes

e6d31ed

gchaps reviewed Jan 20, 2022

View reviewed changes

nreese and others added 7 commits January 23, 2022 07:05

Update docs/maps/import-geospatial-data.asciidoc

f9da288

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

384b992

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

53ce3ef

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

256485a

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

3a369f0

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/maps/import-geospatial-data.asciidoc

3c576c2

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

review feedback

9d1838c

Merge branch 'main' into drawing_docs

2635980

nreese requested a review from gchaps January 23, 2022 14:12

Merge branch 'main' into drawing_docs

ba38f84

gchaps approved these changes Jan 28, 2022

View reviewed changes

docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved

docs/maps/import-geospatial-data.asciidoc Show resolved Hide resolved

nreese and others added 2 commits January 31, 2022 06:18

Update docs/maps/import-geospatial-data.asciidoc

a0ae4ff

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

fix formatting of nested bullet

e903d39

nickpeihl approved these changes Jan 31, 2022

View reviewed changes

nreese merged commit b6a0a23 into elastic:main Feb 1, 2022

kibanamachine mentioned this pull request Feb 1, 2022

[8.0] [Maps] drawing layer documentation (#123373) #124229

Merged

kibanamachine mentioned this pull request Feb 1, 2022

[7.14] [Maps] drawing layer documentation (#123373) #124230

Merged

kibanamachine mentioned this pull request Feb 1, 2022

[7.15] [Maps] drawing layer documentation (#123373) #124231

Merged

kibanamachine mentioned this pull request Feb 1, 2022

[7.16] [Maps] drawing layer documentation (#123373) #124232

Merged

kibanamachine mentioned this pull request Feb 1, 2022

[7.17] [Maps] drawing layer documentation (#123373) #124233

Merged


		. Click layer name in legend and select Edit features.

		When feature editing is open, a feature editing toolbox is displayed on the left side of the map.

	When feature editing is open, a feature editing toolbox is displayed on the left side of the map.
	A feature editing toolbox appears on the left side of the map.


		. Click Add layer.

		. Set Scaling to Limit results to 10,000.

Conversation

nreese commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 19, 2022

Uh oh!

elasticmachine commented Jan 19, 2022

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gchaps Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

gchaps Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

nreese Jan 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nreese commented Jan 23, 2022

Uh oh!

nreese commented Jan 28, 2022

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented Jan 31, 2022

💚 Build Succeeded

History

Uh oh!

gchaps commented Jan 31, 2022

Uh oh!

nickpeihl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nickpeihl Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

nreese Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 1, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nreese commented Jan 19, 2022 •

edited

Loading