Skip to content

Support for superuser not having write access#123337

Merged
tylersmalley merged 16 commits intoelastic:mainfrom
tylersmalley:superuser-read
Jan 24, 2022
Merged

Support for superuser not having write access#123337
tylersmalley merged 16 commits intoelastic:mainfrom
tylersmalley:superuser-read

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Jan 19, 2022 •
edited
Loading

Changes in response to elastic/elasticsearch#81400

Some tests needed to be skipped as the data archive was not supported:

Likely root cause: org.elasticsearch.gateway.CorruptStateException: Format version is not supported. Upgrading to [8.1.0] is only supported from version [7.17.0]

For anyone testing this, or investigating the skipped tests. It's likely that the failures are only when running against the current version of Elasticsearch. I did this at #123338. If you would like to do this locally, you can set KBN_ES_SNAPSHOT_USE_UNVERIFIED=true. More details can be found in the docs.

TODO:

  • Create issues for any skipped tests after merging.

tylersmalley and others added 7 commits January 18, 2022 22:02
@tylersmalley
Support for superuser not having write access
82c49a7 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
TEMP: Use nightly ES snapshot
53d71a0 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Adds mocks
9f6d763 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@nchaulet
Fix fleet tests
b412547
@tsullivan
Fix Reporting ILM Tests
34060c6
@tylersmalley
Merge pull request #11 from tsullivan/superuser-read-es-head
1b38274
@kibanamachine
Merge branch 'main' into superuser-read-es-head
0a635ef
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Jan 20, 2022

@elasticmachine merge upstream

@tylersmalley tylersmalley mentioned this pull request Jan 20, 2022
Closed
@tylersmalley
Skip test
f9a9596 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Update manifest
6d8daee 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Disable legacy dataArchive
ceb9880 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
TEMP
62db848 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Skip migration test
ba56964 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Skip test
ea32b0f 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the superuser-read branch 2 times, most recently from b4d2eb1 to ea32b0f Compare January 22, 2022 22:48
@tylersmalley
Remove changes used in testing
3f0c1d4 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 23, 2022
@tylersmalley tylersmalley marked this pull request as ready for review January 23, 2022 00:13
@tylersmalley tylersmalley requested review from a team as code owners January 23, 2022 00:13
tsullivan
tsullivan approved these changes Jan 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 24, 2022
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Jan 24, 2022

All passed - for some reason, some were not reported.

@tylersmalley tylersmalley merged commit 23739f5 into elastic:main Jan 24, 2022
@tylersmalley tylersmalley deleted the superuser-read branch January 24, 2022 17:39
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 24, 2022

💔 All backports failed

Status Branch Result
❌ 8.0 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 123337

Questions ?

Please refer to the Backport tool documentation

@tylersmalley tylersmalley mentioned this pull request Jan 24, 2022
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jan 24, 2022
@tylersmalley
Support for superuser not having write access (elastic#123337)
5ee8b3b 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

# Conflicts:
#	src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts
tylersmalley added a commit that referenced this pull request Jan 24, 2022
@tylersmalley @kibanamachine
Support for superuser not having write access (#123337) (#123639)
73708fd 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

# Conflicts:
#	src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit to jbudz/kibana that referenced this pull request Jan 27, 2022
@jbudz
[7.17] skip es_kibana_version_compatibility.test.ts pending backport
7d63bb6 
Testing against 8.0 requires system index write access introduced in
elastic#123337.  This adds a temporary
skip while the backport is in progress.
@jbudz jbudz mentioned this pull request Jan 27, 2022
Merged
jbudz pushed a commit to jbudz/kibana that referenced this pull request Jan 27, 2022
@tylersmalley @kibanamachine @jbudz
Support for superuser not having write access (elastic#123337) (elast…
7fa4f1c 
…ic#123639)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 23739f5)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit that referenced this pull request Jan 27, 2022
@jbudz
[7.17] skip es_kibana_version_compatibility.test.ts pending backport (#…
f180db9 
…123961)

Testing against 8.0 requires system index write access introduced in
#123337.  This adds a temporary
skip while the backport is in progress.
This was referenced Jan 28, 2022
Closed
Merged
@tylersmalley tylersmalley mentioned this pull request Feb 23, 2022
Merged
@kibanamachine kibanamachine mentioned this pull request Feb 24, 2022
Merged
@gbamparop gbamparop mentioned this pull request Mar 1, 2022
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 3, 2022
@tylersmalley @nchaulet
@tsullivan @kibanamachine
Support for superuser not having write access (elastic#123337)
ad19d31 
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@liza-mae liza-mae mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

@rudolf rudolf rudolf approved these changes

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@joshdover joshdover joshdover approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Kibana-Operations Team v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tylersmalley @elasticmachine @kibana-ci @kibanamachine @tsullivan @rudolf @joshdover @jbudz @nchaulet