Functional test runner creates system_indices_superuser by pheyos · Pull Request #124008 · elastic/kibana

pheyos · 2022-01-28T10:36:47Z

Summary

This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists.

Details

Uses the elastic superuser (or the user provided in the test URL) for the ES version check and to create the system_indices_superuser
This system_indices_superuser is then used in the es service for the rest of the tests

Closes #123994
Closes #124442

pheyos · 2022-01-28T10:36:52Z

As of the initial commit in this PR, we have some duplicated code because the system_indices_superuser is still also created in the native realm: https://github.com/elastic/kibana/blob/main/packages/kbn-es/src/utils/native_realm.js#L132 - not sure if this is still needed there or if this bit could be removed.

…on tests

pheyos · 2022-01-31T07:33:37Z

@elasticmachine merge upstream

azasypkin

Changes in Spaces API integration tests config LGTM. Just left one question.

test/common/services/security/system_indices_user.ts

pheyos · 2022-02-02T07:49:33Z

@elasticmachine merge upstream

packages/kbn-test/src/functional_test_runner/functional_test_runner.ts

…t-service use independent client in ftr for version check, share creation logic

elasticmachine · 2022-02-03T11:37:27Z

Pinging @elastic/apm-ui (Team:apm)

pheyos · 2022-02-03T22:17:26Z

@jbudz sure, will do.

pheyos · 2022-02-04T08:40:27Z

@elasticmachine merge upstream

kibana-ci · 2022-02-04T10:10:17Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/test`	203	208	+5

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`kibana`	936	937	+1

Unknown metric groups

API count

id	before	after	diff
`@kbn/test`	235	244	+9

History

💛 Build #21591 was flaky 94a5512
💔 Build #21580 failed 7064fca
💚 Build #21241 succeeded c934c54
💚 Build #20979 succeeded d0f5ac5
💚 Build #20596 succeeded 26bfffa
💚 Build #20349 succeeded 6ebe1ec

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

kibanamachine · 2022-02-04T10:24:10Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.2.0

If any of these should not be on your pull request, please manually remove them.

This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists. (cherry picked from commit 8989ead)

kibanamachine · 2022-02-04T10:26:55Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.0	Backport failed because of merge conflicts
✅	8.1
❌	7.17	Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 124008

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists. (cherry picked from commit 8989ead) # Conflicts: # x-pack/test/rule_registry/common/services/cluster_client.ts

…24668) This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists. (cherry picked from commit 8989ead) Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>

…24669) This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists. (cherry picked from commit 8989ead) # Conflicts: # x-pack/test/rule_registry/common/services/cluster_client.ts

sorenlouv

apm changes lgtm

This PR fixes the functional test runner for execution against cloud (and other existing deployments) by making sure the system_indices_superuser exists.

Backport of * Functional test runner creates system_indices_superuser (#124008) * FTR - check ES security before creating system_indices_superuser (#124948)

Functional test runner creates system_indices_superuser

ddc9e02

pheyos self-assigned this Jan 28, 2022

pheyos requested review from spalger and tylersmalley January 28, 2022 10:37

Make esWithoutSystemIndices service available in spaces_api_integrati…

6ebe1ec

…on tests

pheyos added v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Jan 28, 2022

pheyos marked this pull request as ready for review January 28, 2022 13:24

pheyos requested review from a team as code owners January 28, 2022 13:24

Merge branch 'main' into system_indices_user

26bfffa

azasypkin approved these changes Jan 31, 2022

View reviewed changes

test/common/services/security/system_indices_user.ts Outdated Show resolved Hide resolved

pheyos added 2 commits February 1, 2022 09:43

Merge branch 'main' into system_indices_user

b7dc70c

Adjust default users tests for cloud env

d0f5ac5

Merge branch 'main' into system_indices_user

c934c54

spalger reviewed Feb 2, 2022

View reviewed changes

packages/kbn-test/src/functional_test_runner/functional_test_runner.ts Outdated Show resolved Hide resolved

spalger and others added 3 commits February 2, 2022 13:03

use independent client in ftr for version check, share creation logic

4bbc130

maintain the alternate TEST_CLOUD detection logic for cypress tests

f743fc3

Merge pull request #1 from spalger/implement/ftr-version-check-withou…

f688b61

…t-service use independent client in ftr for version check, share creation logic

pheyos requested a review from a team February 3, 2022 11:37

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Feb 3, 2022

pheyos added 3 commits February 3, 2022 12:40

Remove esSupertestWithoutAuth from spaces test config

9ff30dc

Fix esSupertestWithoutAuth removal from config

9dcb689

Merge branch 'main' into system_indices_user

7064fca

pheyos added the v7.17.1 label Feb 3, 2022

Merge branch 'main' into system_indices_user

8538931

dgieselaar approved these changes Feb 4, 2022

View reviewed changes

pheyos merged commit 8989ead into elastic:main Feb 4, 2022

pheyos deleted the system_indices_user branch February 4, 2022 10:23

kibanamachine added the v8.2.0 label Feb 4, 2022

kibanamachine mentioned this pull request Feb 4, 2022

[8.1] Functional test runner creates system_indices_superuser (#124008) #124668

Merged

pheyos mentioned this pull request Feb 4, 2022

[8.0] Functional test runner creates system_indices_superuser (#124008) #124669

Merged

liza-mae mentioned this pull request Feb 7, 2022

Functional tests not running on cloud clusters >=8.0 #123994

Closed

pheyos mentioned this pull request Feb 8, 2022

FTR - check ES security before creating system_indices_superuser #124948

Merged

spalger removed the v7.17.1 label Feb 9, 2022

sorenlouv reviewed Feb 9, 2022

View reviewed changes

liza-mae mentioned this pull request Mar 7, 2022

[FTR] system_indices_superuser security exception on 7.17 #127067

Closed

liza-mae mentioned this pull request Mar 9, 2022

[7.17] Functional test runner creates system_indices_superuser (#124008) #127387

Closed

pheyos mentioned this pull request Mar 10, 2022

[7.17] Functional test runner creates system_indices_superuser #127435

Merged

pheyos added v7.17.2 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 10, 2022

flash1293 mentioned this pull request Mar 30, 2022

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/visualize/index·ts - visualize app "before all" hook in "visualize app" #128789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Functional test runner creates system_indices_superuser#124008

Functional test runner creates system_indices_superuser#124008
pheyos merged 14 commits intoelastic:mainfrom
pheyos:system_indices_user

pheyos commented Jan 28, 2022 •

edited

Loading

Uh oh!

pheyos commented Jan 28, 2022 •

edited

Loading

Uh oh!

pheyos commented Jan 31, 2022

Uh oh!

azasypkin left a comment

Uh oh!

Uh oh!

pheyos commented Feb 2, 2022

Uh oh!

Uh oh!

elasticmachine commented Feb 3, 2022

Uh oh!

pheyos commented Feb 3, 2022

Uh oh!

pheyos commented Feb 4, 2022

Uh oh!

kibana-ci commented Feb 4, 2022

API count

Uh oh!

kibanamachine commented Feb 4, 2022

Uh oh!

kibanamachine commented Feb 4, 2022

Uh oh!

sorenlouv left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

pheyos commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Uh oh!

pheyos commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pheyos commented Jan 31, 2022

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pheyos commented Feb 2, 2022

Uh oh!

Uh oh!

elasticmachine commented Feb 3, 2022

Uh oh!

pheyos commented Feb 3, 2022

Uh oh!

pheyos commented Feb 4, 2022

Uh oh!

kibana-ci commented Feb 4, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

History

Uh oh!

kibanamachine commented Feb 4, 2022

Uh oh!

kibanamachine commented Feb 4, 2022

💔 Some backports could not be created

How to fix

Questions ?

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pheyos commented Jan 28, 2022 •

edited

Loading

pheyos commented Jan 28, 2022 •

edited

Loading