[Security Solution] Fixes alerts table Full screen button overlap
#122901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue reported in <elastic#122231> where the alerts table's `Full screen` button, recently [moved to the right side of `EuiDataGrid`](elastic/eui#5334) in [EUI 43.0.0](https://elastic.github.io/eui/#/package/changelog), overlapped the existing view selector. ### Details In the `8.0` release of the Security Solution, the alerts table `Full screen` button appears above the table on the **left**, per the screenshot below:  _Above: The alerts table `Full screen` button in `8.0`_ Starting with `8.1` (via [EUI 43.0.0](https://elastic.github.io/eui/#/package/changelog)), `EuiDataGrid`'s `Full screen` button has been [moved to the right side of `EuiDataGrid`](elastic/eui#5334), per the screenshot below:  _Above: `EuiDataGrid`'s full screen icon has moved from left to right_ The new location of the `Full screen` button overlapped the existing alerts table view selector, per the `Before` screenshot below: #### Before  _Above: Overlapping icons reported in <https://github.com/elastic/kibana/issues/122231>_ This PR fixes the overlap, per the `After` screenshots below: #### After Chrome `97.0.4692.71`:  Firefox `96.0`:  Safari `15.2`: 
andrew-goldstein
added
bug
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kqualters-elastic
approved these changes
Jan 13, 2022
janmonschke
approved these changes
Jan 13, 2022
andrew-goldstein
removed
the
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] Fixes alerts table
Full screenbutton overlapThis PR fixes an issue reported in #122231 where the alerts table's
Full screenbutton, recently moved to the right side ofEuiDataGridin EUI 43.0.0, overlapped the existing view selector.Details
In the
8.0release of the Security Solution, the alerts tableFull screenbutton appears above the table on the left, per the screenshot below:Above: The alerts table
Full screenbutton in8.0Starting with
8.1(via EUI 43.0.0),EuiDataGrid'sFull screenbutton has been moved to the right side ofEuiDataGrid, per the screenshot below:Above:
EuiDataGrid's full screen icon has moved from left to rightThe new location of the
Full screenbutton overlapped the existing alerts table view selector, per theBeforescreenshot below:Before
Above: Overlapping icons reported in #122231
This PR fixes the overlap, per the
Afterscreenshots below:After
Chrome
97.0.4692.71:Firefox
96.0:Safari
15.2: