[Upgrade Assistant] Fix ml upgrade status check#121646
Merged
sabarasaba merged 6 commits intoelastic:7.17from Dec 22, 2021
Merged
[Upgrade Assistant] Fix ml upgrade status check#121646sabarasaba merged 6 commits intoelastic:7.17from
sabarasaba merged 6 commits intoelastic:7.17from
Conversation
sabarasaba
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
yuliacech
approved these changes
Dec 21, 2021
Contributor
yuliacech
left a comment
yuliacech
left a comment
There was a problem hiding this comment.
Thank you for fixing this, @sabarasaba!
I tested locally and all looks good, code changes LGTM too 👍
This was referenced Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121313
Summary
This PR uses a newly implemented api from ES (elastic/elasticsearch#81641) in order to have a more accurate representation of the model snapshot upgrade. Nothing should be noticeable different from before, except that we now pull the status from a different api endpoint.
How to test
yarn es snapshot --license=trial -E path.data=./data-6.8.20and kibana withyarn start. You can use this snapshot data-6.8.20.zip I created that contains a ML deprecation that requires upgrading.Stack Management->Upgrade Assistant->ES deprecationsNote: when this PR is merged, I'll create a new one for getting this change into main and 8.x