Skip to content

[Upgrade Assistant] Fix ml model upgrade status check#121617

Closed
sabarasaba wants to merge 5 commits intoelastic:7.16from
sabarasaba:ua/fix_ml_model_upgrade_status_check
Closed

[Upgrade Assistant] Fix ml model upgrade status check#121617
sabarasaba wants to merge 5 commits intoelastic:7.16from
sabarasaba:ua/fix_ml_model_upgrade_status_check

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Dec 20, 2021

Fixes #121313

Summary

This PR uses a newly implemented api from ES (elastic/elasticsearch#81641) in order to have a more accurate representation of the model snapshot upgrade. Nothing should be noticeable different from before, except that we now pull the status from a different api endpoint.

How to test

  1. Start elasticsearch with yarn es snapshot --license=trial -E path.data=./data-6.8.20 and kibana with yarn start. You can use this snapshot data-6.8.20.zip I created that contains a ML deprecation that requires upgrading.
  2. Navigate to Stack Management -> Upgrade Assistant -> ES deprecations
  3. Verify that upgrading the ML deprecation in the table follows the usual flow.

Note: when this PR is merged, I'll create a new one for getting this change into main and 8.x

@sabarasaba sabarasaba self-assigned this Dec 20, 2021
@sabarasaba sabarasaba added backport:skip This PR does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.16.2 labels Dec 20, 2021
@sabarasaba sabarasaba requested a review from yuliacech December 20, 2021 14:39
@sabarasaba sabarasaba marked this pull request as ready for review December 20, 2021 14:39
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba
Copy link
Copy Markdown
Member Author

Closing in favour of #121646 which points to 7.17

@sabarasaba sabarasaba closed this Dec 20, 2021
@sabarasaba sabarasaba deleted the ua/fix_ml_model_upgrade_status_check branch December 20, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants