Skip to content

[Security Solution][Endpoint] Improve endpoint performance with Trusted Apps path wildcards#120789

Closed
ashokaditya wants to merge 3 commits intoelastic:7.16from
ashokaditya:fix/olm-improve_endpoint_perf_with_path_wildcard_TA-2293
Closed

[Security Solution][Endpoint] Improve endpoint performance with Trusted Apps path wildcards#120789
ashokaditya wants to merge 3 commits intoelastic:7.16from
ashokaditya:fix/olm-improve_endpoint_perf_with_path_wildcard_TA-2293

Conversation

@ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Dec 8, 2021

Summary

Displays a soft warning when the matching path has wildcard executable name. If the wildcard path has a proper executable in the path then it adds a process.name value to the TA artifact.

image

Linux entries
image

Mac entries
image

Windows entries
iamge

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ashokaditya ashokaditya self-assigned this Dec 8, 2021
@ashokaditya ashokaditya added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.2 v7.17.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Dec 8, 2021
@ashokaditya ashokaditya force-pushed the fix/olm-improve_endpoint_perf_with_path_wildcard_TA-2293 branch 3 times, most recently from e256d13 to 9ed7a59 Compare December 9, 2021 09:37
@ashokaditya ashokaditya force-pushed the fix/olm-improve_endpoint_perf_with_path_wildcard_TA-2293 branch from 9ed7a59 to fb59c64 Compare December 9, 2021 10:49
@kibana-ci
Copy link

kibana-ci commented Dec 9, 2021

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / when rendering the PolicyTrustedAppsList should navigate to trusted apps page when view full details action is clicked
  • [job] [logs] Jest Tests #7 / when using the ArtifactEntryCard component with exceptions/event filters should display title and who has created and updated it last
  • [job] [logs] Jest Tests #7 / when using the ArtifactEntryCard component with trusted apps should display multiple OSs in the criteria conditions
  • [job] [logs] Jest Tests #7 / when using the ArtifactEntryCard component with trusted apps should display OS and criteria conditions
  • [job] [logs] Jest Tests #7 / when using the ArtifactEntryCard component with trusted apps should display title and who has created and updated it last
  • [job] [logs] Jest Tests #7 / when using the ArtifactEntryCardMinified component with trusted apps should collapse/uncollapse critera conditions
  • [job] [logs] Jest Tests #7 / When using the RemoveTrustedAppFromPolicyModal component should show success toast and close modal when removed is successful

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +601.0B

History

  • 💔 Build #12362 failed 9ed7a59db7b2302b9e2737d4f05729b3577a2bdf
  • 💔 Build #12199 failed 1fe5d94627b37723a37e05aee7eee7d74e9f83a5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya
Copy link
Member Author

ashokaditya commented Dec 9, 2021

same as elastic/kibana/pull/120349

@ashokaditya ashokaditya closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.2 v7.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants