Merged
Conversation
thompsongl
added
release_note:skip
NB: conditional became `type === 'success' ? 'success' : type` after find&replace, which felt fairly redundant, so I simplified it
- caused local unsaved changes shenanigans, somehow
pgayvallet
approved these changes
Nov 16, 2021
Contributor
Author
|
@elasticmachine merge upstream |
byronhulcher
approved these changes
Nov 16, 2021
Contributor
byronhulcher
left a comment
byronhulcher
left a comment
There was a problem hiding this comment.
Thanks @constancecchen!
peteharverson
approved these changes
Nov 17, 2021
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
ML, Transforms and Data Visualizer plugins LGTM (code and did quick visual check of pages)
weltenwort
approved these changes
Nov 17, 2021
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
infra and monitoring plugin changes LGTM, thank you
ThomThomson
approved these changes
Nov 17, 2021
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Code only review - Presentation team changes LGTM!
mattkime
approved these changes
Nov 17, 2021
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
app services change lgtm
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elastic/apm-ui @elastic/kibana-vis-editors @elastic/security-asset-management @elastic/security-onboarding-and-lifecycle-mgt Merging this today so we can continue with further EUI version upgrades. |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
* eui to v41.0.0 * update eui i18n tokens * sass tokens * EuiLoadingKibana * EuiCodeEditor * subdued * betaBadgeProps * EuiCodeEditor null-loader * src secondary -> success * [enterprise_search] Deprecate 'secondary' color prop * [apm] Deprecate 'secondary' color prop * [canvas] Deprecate 'secondary' color prop * [cases] Deprecate 'secondary' color prop * [cross_cluster_replication] Deprecate 'secondary' color prop * [data_enhanced] Deprecate 'secondary' color prop * [data_visualizer] Deprecate 'secondary' color prop * [fleet] Deprecate 'secondary' color prop * [index_management] Deprecate 'secondary' color prop * [infra] Deprecate 'secondary' color prop * [ingest_pipelines] Deprecate 'secondary' color prop * [maps] Deprecate 'secondary' color prop * [ml] Deprecate 'secondary' color prop * [monitoring] Deprecate 'secondary' color prop * [observability] Deprecate 'secondary' color prop NB: conditional became `type === 'success' ? 'success' : type` after find&replace, which felt fairly redundant, so I simplified it * [osquery] Deprecate 'secondary' color prop * [painless_lab] Deprecate 'secondary' color prop * [remote_clusters] Deprecate 'secondary' color prop * [rollup] Deprecate 'secondary' color prop * [security] Deprecate 'secondary' color prop * [security_solution] Deprecate 'secondary' color prop NB: several conditional became `type === 'success' ? 'success' : type` after find&replace, which felt fairly redundant, so I simplified them * [snapshot_restore] Deprecate 'secondary' color prop * [spaces] Deprecate 'secondary' color prop * [transform] Deprecate 'secondary' color prop * [triggers_actions_ui] Deprecate 'secondary' color prop * [uptime] Deprecate 'secondary' color prop * [watcher] Deprecate 'secondary' color prop * [infra] replace ambiguous 'secondary' color - GaugesSectionVis doesn't appear to use the color property but it's required by the SeriesOverrides types, so changing it just in case * [examples] Deprecate 'secondary' color prop * [uptime] deprecate 'subdued' prop on EuiButtonIcon * revert EuiKeyPadMenuItem betaBadge props * mobileOptions * examples/ updates * fix brace import * fix type exports * update expressions_explorer requiredBundles * remove make_id mocks * snapshot updates * fix import 🤦 * Fix `ReferenceError: ace is not defined` Jest failures * Remove unused brace import (?) - Assuming here, as no code editor is actually being used in this file * Fix failing Jest test due to EuiCodeEditor moving to es_ui_shared plugin + minor cleanup of `jest.mock()`s * Fix failing Jest test due to snapshot update * Fix failing `TypeError: Cannot read properties of undefined (reading 'euiBorderRadius')` Jest test - since this is being mount()'d, EuiThemeProvider as a wrapper is needed to prevent the failure * access uiSettings * Move react-ace dependency into kbn-ui-shared-deps-npm * Revert App Search shenanigans - caused local unsaved changes shenanigans, somehow * secondary -> success Co-authored-by: Constance Chen <constance.chen.3@gmail.com> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance Chen <constance.chen@elastic.co>
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
* eui to v41.0.0 * update eui i18n tokens * sass tokens * EuiLoadingKibana * EuiCodeEditor * subdued * betaBadgeProps * EuiCodeEditor null-loader * src secondary -> success * [enterprise_search] Deprecate 'secondary' color prop * [apm] Deprecate 'secondary' color prop * [canvas] Deprecate 'secondary' color prop * [cases] Deprecate 'secondary' color prop * [cross_cluster_replication] Deprecate 'secondary' color prop * [data_enhanced] Deprecate 'secondary' color prop * [data_visualizer] Deprecate 'secondary' color prop * [fleet] Deprecate 'secondary' color prop * [index_management] Deprecate 'secondary' color prop * [infra] Deprecate 'secondary' color prop * [ingest_pipelines] Deprecate 'secondary' color prop * [maps] Deprecate 'secondary' color prop * [ml] Deprecate 'secondary' color prop * [monitoring] Deprecate 'secondary' color prop * [observability] Deprecate 'secondary' color prop NB: conditional became `type === 'success' ? 'success' : type` after find&replace, which felt fairly redundant, so I simplified it * [osquery] Deprecate 'secondary' color prop * [painless_lab] Deprecate 'secondary' color prop * [remote_clusters] Deprecate 'secondary' color prop * [rollup] Deprecate 'secondary' color prop * [security] Deprecate 'secondary' color prop * [security_solution] Deprecate 'secondary' color prop NB: several conditional became `type === 'success' ? 'success' : type` after find&replace, which felt fairly redundant, so I simplified them * [snapshot_restore] Deprecate 'secondary' color prop * [spaces] Deprecate 'secondary' color prop * [transform] Deprecate 'secondary' color prop * [triggers_actions_ui] Deprecate 'secondary' color prop * [uptime] Deprecate 'secondary' color prop * [watcher] Deprecate 'secondary' color prop * [infra] replace ambiguous 'secondary' color - GaugesSectionVis doesn't appear to use the color property but it's required by the SeriesOverrides types, so changing it just in case * [examples] Deprecate 'secondary' color prop * [uptime] deprecate 'subdued' prop on EuiButtonIcon * revert EuiKeyPadMenuItem betaBadge props * mobileOptions * examples/ updates * fix brace import * fix type exports * update expressions_explorer requiredBundles * remove make_id mocks * snapshot updates * fix import 🤦 * Fix `ReferenceError: ace is not defined` Jest failures * Remove unused brace import (?) - Assuming here, as no code editor is actually being used in this file * Fix failing Jest test due to EuiCodeEditor moving to es_ui_shared plugin + minor cleanup of `jest.mock()`s * Fix failing Jest test due to snapshot update * Fix failing `TypeError: Cannot read properties of undefined (reading 'euiBorderRadius')` Jest test - since this is being mount()'d, EuiThemeProvider as a wrapper is needed to prevent the failure * access uiSettings * Move react-ace dependency into kbn-ui-shared-deps-npm * Revert App Search shenanigans - caused local unsaved changes shenanigans, somehow * secondary -> success Co-authored-by: Constance Chen <constance.chen.3@gmail.com> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance Chen <constance.chen@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eui@40.1.0⏩eui@41.0.0All breaking changes have been accounted for. However, check your app for changes to:
EuiCodeEditoresUiSharedor converted to<CodeEditor />braceimports and validate that they are still neededsuccessis visually identical tosecondarytextis visually indistinguishable fromsubduedreact-acehas been added to thekbn-ui-shared-depspackage to mitigate plugin bundle size increases. This is more similar to how it was included in Kibana when it was part of EUI.41.0.0EuiAutoSizercomponent for setting dimensions on virtualized lists (#5278)testenvmock forEuiAutoSizer(#5278)useEuiTextDiffto aspaninstead ofdiv(#5323)childrenforEuiMarkfromstringtoReactNode(#5323)renderprop toEuiI18n(#5236)Bug fixes
align: centerfor mobile version ofEuiTableRowCell(#5323)endDateControlclassNameinEuiDatePickerRange(#5329)EuiMarkdownEditorintercepting all drop events on the page (#5340)Breaking changes
EuiCodeEditor(#5323)betaBadgeLabel,betaBadgeTooltipContent,betaBadgeTitleprops fromEuiCard(#5323)EuiLoadingKibana(#5323)secondarycolor prop options (#5323)subduedcolor prop option fromEuiButtonIcon(#5323)panelPaddingSizefromEuiPageContent(#5323)makeId(#5323)EuiTableRowCell(#5323)$euiColorSecondaryand$euiColorSecondaryText(#5345)