[EuiAutoSizer] AutoSizer wrapper and testenv mock#5278
Merged
thompsongl merged 11 commits intoelastic:masterfrom Oct 28, 2021
Merged
[EuiAutoSizer] AutoSizer wrapper and testenv mock#5278thompsongl merged 11 commits intoelastic:masterfrom
AutoSizer wrapper and testenv mock#5278thompsongl merged 11 commits intoelastic:masterfrom
Conversation
thompsongl
changed the title
AutoSizer wrapper and testenv mockAutoSizer wrapper and testenv mock
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
chandlerprall
approved these changes
Oct 27, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Tested component additions/changes in the new docs example
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5278/ |
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
* add euiautosizer * use euiautosizer * use euiautosizer testenv mock * CL * docs * props table * simplify wrapper * add data-eui attr to testenv mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4446 by adding a new component that is a wrapper around
AutoSizer(react-virtualized-auto-sizer) that can be mocked using the testnev setup, which allows for ensuring calculable dimensions forreact-windowvirtualized components.EuiAutoSizercomponentAutoSizerAutoSizercompletely, if we see opportunitytestenvmock forEuiAutoSizerAs we start to use
EuiSelectablein more places, it's important to have better testing output from its underlying components.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile