Skip to content

[8.0] Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)#116539

Merged
spalger merged 3 commits intoelastic:8.0from
kibanamachine:backport/8.0/pr-116527
Nov 1, 2021
Merged

[8.0] Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)#116539
spalger merged 3 commits intoelastic:8.0from
kibanamachine:backport/8.0/pr-116527

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 8.0:

This reverts commit bacd7f9.

Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Nov 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1074 1062 -12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 243 234 -9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1011.1KB 978.1KB -33.0KB
dashboard 282.0KB 282.0KB -2.0B
total -33.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.6KB 17.3KB -275.0B
presentationUtil 64.0KB 62.8KB -1.2KB
total -1.5KB
Unknown metric groups

API count

id before after diff
presentationUtil 271 262 -9

References to deprecated APIs

id before after diff
canvas 70 67 -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spalger

@spalger spalger merged commit 4359e70 into elastic:8.0 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants