[7.x] Automated Curation Backports (#114545) (#114717) (#115090) (#114549) by JasonStoltz · Pull Request #115650 · elastic/kibana

JasonStoltz · 2021-10-19T20:34:29Z

Backports the following commits to 7.x:

Handle deletes (elastic#114545)
[App Search] Wired up organic results on Curation Suggestions view ([App Search] Wired up organic results on Curation Suggestions view #114717)
[App Search] Added a History tab to the Automated Curation detail view ([App Search] Added a History tab to the Automated Curation detail view #115090)
Check platinum license ([App Search] Added platinum license check before showing Suggestions #114549)

…lastic#114717)

elastic#115090)

kibanamachine · 2021-10-20T04:16:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b16de0b
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Jest Unit Tests

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of other user when submitting form and closes dialog

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115473

Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:215:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password form

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115474

Stack Trace

Error: Unable to find an element with the text: /Enter your current password/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

<div
  data-eui="EuiFlyout"
  role="dialog"
>
  <button
    data-test-subj="euiFlyoutCloseButton"
    type="button"
  />
  <div
    class="euiFlyoutHeader euiFlyoutHeader--hasBorder"
  >
    <h2
      class="euiTitle euiTitle--medium"
      id="id-0.934268346356254"
    >
      Change password
    </h2>
  </div>
  <div
    class="euiFlyoutBody"
  >
    <div
      class="euiFlyoutBody__overflow"
      tabindex="0"
    >
      <div
        class="euiFlyoutBody__overflowContent"
      >
        <form
          class="euiForm"
          novalidate=""
        >
          <div
            class="euiFormRow"
            id="id-0.028685948908866-row"
          >
            <div
              class="euiFormRow__labelWrapper"
            >
              <label
                class="euiFormLabel euiFormRow__label"
                for="id-0.028685948908866"
              >
                User
              </label>
            </div>
            <div
              class="euiFormRow__fieldWrapper"
            >
              <div
                class="euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow"
                id="id-0.028685948908866"
              >
                <div
                  class="euiFlexItem euiFlexItem--flexGrowZero"
                >
                  <span
                    data-euiicon-type="user"
                  />
                </div>
                <div
                  class="euiFlexItem"
                >
                  <div
                    class="euiSpacer euiSpacer--xs"
                  />
                  <div
                    class="euiText euiText--medium"
                  >
                    jdoe
                  </div>
                  <div
                    class="euiSpacer euiSpacer--xs"
                  />
                </div>
              </div>
            </div>
          </div>
          <div
            class="euiFormRow"
            id="id-0.5715988251322079-row"
          >
            <div
              class="euiFormRow__labelWrapper"
            >
              <label
                class="euiFormLabel euiFormRow__label euiFormLabel-isFocused"
                for="id-0.5715988251322079"
              >
                Current password
              </label>
            </div>
            <div
              class="euiFormRow__fieldWrapper"
            >
              <div
                class="euiFormControlLayout euiFormControlLayout--group"
              >
                <div
                  class="euiFormControlLayout__childrenWrapper"
                >
                  <input
                    autocomplete="current-password"
                    class="euiFieldPassword euiFieldPassword--inGroup euiFieldPassword--withToggle"
                    id="id-0.5715988251322079"
                    name="current_password"
                    type="password"
                    value=""
                  />
                  <div
                    class="euiFormControlLayoutIcons"
                  >
                    <span
                      class="euiFormControlLayoutCustomIcon"
                    >
                      <span
                        aria-hidden="true"
                        class="euiFormControlLayoutCustomIcon__icon"
                        data-euiicon-type="lock"
                      />
                    </span>
                  </div>
                </div>
                <button
                  aria-label="Show password as plain text. Note: this will visually expose your password on the screen."
                  class="euiButtonIcon euiButtonIcon--primary euiButtonIcon--empty euiButtonIcon--xSmall euiFormControlLayout__append"
                  title="Show password as plain text. Note: this will visually expose your password on the screen."
                  type="button"
                >
                  <span
                    aria-hidden="true"
                    class="euiButtonIcon__icon"
                    color="inherit"
                    data-euiicon-type="eye"
                  />
                </button>
              </div>
            </div>
          </div>
          <div
            class="euiFormRow"
            id="id-0.8464666966792334-row"
          >
            <div
              class="euiFormRow__labelWrapper"
            >
              <label
                class="euiFormLabel euiFormRow__label"
                for="id-0.8464666966792334"
              >
                New password
              </label>
            </div>
            <div
              class="euiFormRow__fieldWrapper"
            >
              <div
                class="euiFormControlLayout euiFormControlLayout--group"
              >
                <div
                  class="euiFormControlLayout__childrenWrapper"
                >
                  <input
                    aria-describedby="id-0.8464666966792334-help-0"
                    autocomplete="new-password"
                    class="euiFieldPassword euiFieldPassword--inGroup euiFieldPassword--withToggle"
                    id="id-0.8464666966792334"
                    name="password"
                    type="password"
                    value=""
                  />
                  <div
                    class="euiFormControlLayoutIcons"
                  >
                    <span
                      class="euiFormControlLayoutCustomIcon"
                    >
                      <span
                        aria-hidden="true"
                        class="euiFormControlLayoutCustomIcon__icon"
                        data-euiicon-type="lock"
                      />
                    </span>
                  </div>
                </div>
                <button
                  aria-label="Show password as plain text. Note: this will visually expose your password on the screen."
                  class="euiButtonIcon euiButtonIcon--primary euiButtonIcon--empty euiButtonIcon--xSmall euiFormControlLayout__append"
                  title="Show password as plain text. Note: this will visually expose your password on the screen."
                  type="button"
                >
                  <span
                    aria-hidden="true"
                    class="euiButtonIcon__icon"
                    color="inherit"
                    data-euiicon-type="eye"
                  />
                </button>
              </div>
              <div
                class="euiFormHelpText euiFormRow__text"
                id="id-0.8464666966792334-help-0"
              >
                Password must be at least 6 characters.
              </div>
            </div>
          </div>
          <div
            class="euiFormRow"
            id="id-0.8741288879546829-row"
          >
            <div
              class="euiFormRow__labelWrapper"
            >
              <label
                class="euiFormLabel euiFormRow__label"
                for="id-0.8741288879546829"
              >
                Confirm password
              </label>
            </div>
            <div
              class="euiFormRow__fieldWrapper"
            >
              <div
                class="euiFormControlLayout euiFormControlLayout--group"
              >
                <div
                  class="euiFormControlLayout__childrenWrapper"
                >
                  <input
                    autocomplete="new-password"
                    class="euiFieldPassword euiFieldPassword--inGroup euiFieldPassword--withToggle"
                    id="id-0.8741288879546829"
                    name="confirm_password"
                    type="password"
                    value=""
                  />
                  <div
                    class="euiFormControlLayoutIcons"
                  >
                    <span
                      class="euiFormControlLayoutCustomIcon"
                    >
                      <span
                        aria-hidden="true"
                        class="euiFormControlLayoutCustomIcon__icon"
                        data-euiicon-type="lock"
                      />
                    </span>
                  </div>
                </div>
                <button
                  aria-label="Show password as plain text. Note: this will visually expose your password on the screen."
                  class="euiButtonIcon euiButtonIcon--primary euiButtonIcon--empty euiButtonIcon--xSmall euiFormControlLayout__append"
                  title="Show password as plain text. Note: this will visually expose your password on the screen."
                  type="button"
                >
                  <span
                    aria-hidden="true"
                    class="euiButtonIcon__icon"
                    color="inherit"
                    data-euiicon-type="eye"
                  />
                </button>
              </div>
            </div>
          </div>
          <input
            hidden=""
            type="submit"
          />
        </form>
      </div>
    </div>
  </div>
  <div
    class="euiFlyoutFooter"
  >
    <div
      class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
    >
      <div
        class="euiFlexItem euiFlexItem--flexGrowZero"
      >
        <button
          class="euiButtonEmpty euiButtonEmpty--primary euiButtonEmpty--flushRight"
          data-test-subj="formFlyoutCancelButton"
          type="button"
        >
          <span
            class="euiButtonContent euiButtonEmpty__content"
          >
            <span
              class="euiButtonEmpty__text"
            >
              Cancel
            </span>
          </span>
        </button>
      </div>
      <div
        class="euiFlexItem euiFlexItem--flexGrowZero"
      >
        <button
          class="euiButton euiButton--primary euiButton--fill"
          data-test-subj="formFlyoutSubmitButton"
          type="button"
        >
          <span
            class="euiButtonContent euiButton__content"
          >
            <span
              class="euiButton__text"
            >
              Change password
            </span>
          </span>
        </button>
      </div>
    </div>
  </div>
</div>
    at waitForWrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:173:27)
    at findByText (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:101:33)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:349:26)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`enterpriseSearch`	1549	1551	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	1.4MB	1.4MB	-8.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`enterpriseSearch`	9.4KB	9.5KB	+189.0B

History

💛 Build #162964 was flaky b16de0b
💚 Build #162946 succeeded a12a4d2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

JasonStoltz added 2 commits October 19, 2021 16:32

Handle deletes (elastic#114545)

9e91119

[App Search] Wired up organic results on Curation Suggestions view (e…

a12a4d2

…lastic#114717)

JasonStoltz changed the title ~~Backport/7.x/pr 114545 and pr 114717~~ [7.x] Handle deletes (#114545) and [App Search] Wired up organic results on Curation Suggestions view (#114717) Oct 19, 2021

JasonStoltz added the backport This PR is a backport of another PR label Oct 19, 2021

byronhulcher changed the title ~~[7.x] Handle deletes (#114545) and [App Search] Wired up organic results on Curation Suggestions view (#114717)~~ [7.x] Automated Curation Backports (#114545) (#114717) Oct 19, 2021

JasonStoltz added 2 commits October 19, 2021 17:01

[App Search] Added a History tab to the Automated Curation detail view (

7d66193

elastic#115090)

Check platinum license (elastic#114549)

b16de0b

byronhulcher changed the title ~~[7.x] Automated Curation Backports (#114545) (#114717)~~ [7.x] Automated Curation Backports (#114545) (#114717) (#115090) (#114549) Oct 19, 2021

byronhulcher approved these changes Oct 19, 2021

View reviewed changes

byronhulcher enabled auto-merge (squash) October 19, 2021 21:10

byronhulcher merged commit c13cbe8 into elastic:7.x Oct 19, 2021

JasonStoltz deleted the backport/7.x/pr-114545-and-pr-114717 branch October 20, 2021 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] Automated Curation Backports (#114545) (#114717) (#115090) (#114549)#115650

[7.x] Automated Curation Backports (#114545) (#114717) (#115090) (#114549)#115650
byronhulcher merged 4 commits intoelastic:7.xfrom
JasonStoltz:backport/7.x/pr-114545-and-pr-114717

JasonStoltz commented Oct 19, 2021 •

edited by byronhulcher

Loading

Uh oh!

kibanamachine commented Oct 20, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JasonStoltz commented Oct 19, 2021 • edited by byronhulcher Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JasonStoltz commented Oct 19, 2021 •

edited by byronhulcher

Loading

kibanamachine commented Oct 20, 2021 •

edited

Loading