[App Search] Handle curation suggestions with a delete operation#114545
[App Search] Handle curation suggestions with a delete operation#114545JasonStoltz merged 2 commits intoelastic:masterfrom
delete operation#114545Conversation
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/documents_source/docvalue_fields·js.maps app documents source docvalue_fields should format date fields as epoch_millis when data driven styling is applied to a date fieldStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| const confirmDialog = (msg: string) => { | ||
| return new Promise(function (resolve) { | ||
| const confirmed = window.confirm(msg); | ||
| return resolve(confirmed); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
At some point we'll want to stop writing new window.confirms and implement EuiConfirmModals but that doesn't need to be now
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
3 similar comments
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Backported in #115650 |
Summary
Suggestions can be of 3 operation types:
create- accepting this suggestion will create a new curationupdate- accepting this suggestion will up an existing curationdelete- accepting this suggestion will delete an existing curationWe need to handle the delete operation differently than
updateandcreate.Checklist
Delete any items that are not applicable to this PR.
For maintainers