Skip to content

[Maps] fix flaky getTile test#114689

Merged
nreese merged 1 commit intoelastic:masterfrom
nreese:getTile_fix2
Oct 12, 2021
Merged

[Maps] fix flaky getTile test#114689
nreese merged 1 commit intoelastic:masterfrom
nreese:getTile_fix2

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Oct 12, 2021

Fixes #114417

#114509 updated the test to ensure the correct feature is used for assert statement. The problem is that there is another place where inconsistent document order returned from _search is causing assertion problems. metafeature.properties.fieldMeta is stringified JSON and this assertion needs to be updated to handle inconsistent ordering of response.

@nreese nreese added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 12, 2021
@nreese nreese requested a review from thomasneirynck October 12, 2021 17:21
@nreese nreese requested a review from a team as a code owner October 12, 2021 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 12, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 26e1d1d into elastic:master Oct 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 12, 2021
Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.16.0 v8.0.0

Projects

None yet

4 participants