[Fleet] Have EPR register new categories / Show category counts by thomasneirynck · Pull Request #114429 · elastic/kibana

thomasneirynck · 2021-10-10T22:54:34Z

Summary

Part of #93084.

With the introduction of elastic/package-registry#735, making following fixes to the EPR-page.

User facing changes

EPR can now introduce new categories in its service, and this will be picked up on the page. the categories in the facets are now a combination of the pre-defined categories in the custom-integration plugin (defined up front, used by plugins), and the categories in EPR (dynamically defined, published by EPR).
category counts show again in the facets (in the little red pills)

Internal changes

Remove unnecessary backend calls on category-change. Only two backend calls are now made on initial page load
- get a list of all categories: this is to retrieve the human-readable version from EPR
- get a list of all packages: this is to be able to populate the counts correctly
Simplify some of the internals
- keyword and category filtering is now purely client-side (the EPR-server no longer filters by category)
- only perform the merge/append operation with EPR-packages and integrations from custom_integrations once
- only perform the merge/append operation with EPR-categories and categories from custom_integrations once

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…egories

elasticmachine · 2021-10-11T12:39:28Z

Pinging @elastic/fleet (Team:Fleet)

…egories

nchaulet · 2021-10-12T17:31:48Z

Tested this locally and the installed integration categories seems broken

thomasneirynck · 2021-10-12T17:54:13Z

thx @nchaulet . This was due to a merge error with master, resolved here #114429 (comment)

...plugins/fleet/public/applications/integrations/sections/epm/screens/home/category_facets.tsx

nchaulet

Tested locally and it works as expected 🚀

kpollich

LGTM

kibanamachine · 2021-10-12T19:08:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: eb7d728
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/maps/get_tile·js.apis Maps endpoints getTile should return vector tile containing document

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 15 times on tracked branches: https://github.com/elastic/kibana/issues/114417

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:06:49]         └-: Maps endpoints
[00:06:49]           └-> "before all" hook in "Maps endpoints"
[00:06:49]           └-> "before all" hook in "Maps endpoints"
[00:06:49]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "mappings.json"
[00:06:49]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "data.json.gz"
[00:06:49]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:06:49]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.22"
[00:06:49]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:06:49]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:06:49]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.20"
[00:06:49]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:06:49]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:06:49]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.21"
[00:06:49]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:06:49]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.21/_AnlnJTLR_SPaJnasARRrA] update_mapping [_doc]
[00:06:52]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.20/_qiJgGMcTTKlw4Hwoa4gCA] update_mapping [_doc]
[00:06:59]             │ info progress: 13241
[00:06:59]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:06:59]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:06:59]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Loading "mappings.json"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Loading "data.json"
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "geo_shapes"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1","max_result_window":"10001","max_inner_result_window":"101"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [drawing_data] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "drawing_data"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "drawing_data" settings {"index":{"number_of_replicas":"0","number_of_shards":"1","max_result_window":"10001","max_inner_result_window":"101"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [meta_for_geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "meta_for_geo_shapes"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "meta_for_geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [antimeridian_points] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "antimeridian_points"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "antimeridian_points" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [antimeridian_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "antimeridian_shapes"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "antimeridian_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [flights] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "flights"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "flights" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [connections] creating index, cause [api], templates [], shards [1]/[0]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "connections"
[00:07:00]             │ debg [x-pack/test/functional/es_archives/maps/data] "connections" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:00]             │ info [o.e.c.m.MetadataMappingService] [node-01] [meta_for_geo_shapes/ME5YPp1hQuqak-mfsmHuKQ] update_mapping [_doc]
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 4 docs into "geo_shapes"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 1 docs into "drawing_data"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 6 docs into "meta_for_geo_shapes"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "antimeridian_points"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "antimeridian_shapes"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "flights"
[00:07:00]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 4 docs into "connections"
[00:07:00]           └-: 
[00:07:00]             └-> "before all" hook in ""
[00:07:09]             └-: getTile
[00:07:09]               └-> "before all" hook for "should return vector tile containing document"
[00:07:09]               └-> should return vector tile containing document
[00:07:09]                 └-> "before each" hook: global before each for "should return vector tile containing document"
[00:07:09]                 └- ✖ fail: apis Maps endpoints  getTile should return vector tile containing document
[00:07:09]                 │       Error: expected { __kbn_metadata_feature__: true,
[00:07:09]                 │   __kbn_is_tile_complete__: true,
[00:07:09]                 │   __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
[00:07:09]                 │   __kbn_feature_count__: 2,
[00:07:09]                 │   fieldMeta: '{"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9583,"count":1},{"key":9252,"count":1}]}},"machine.os.raw":{"categories":{"categories":[{"count":1},{"key":"ios","count":1}]}}}' } to sort of equal { __kbn_feature_count__: 2,
[00:07:09]                 │   __kbn_is_tile_complete__: true,
[00:07:09]                 │   __kbn_metadata_feature__: true,
[00:07:09]                 │   __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
[00:07:09]                 │   fieldMeta: '{"machine.os.raw":{"categories":{"categories":[{"key":"ios","count":1},{"count":1}]}},"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9252,"count":1},{"key":9583,"count":1}]}}}' }
[00:07:09]                 │       + expected - actual
[00:07:09]                 │ 
[00:07:09]                 │          "__kbn_feature_count__": 2
[00:07:09]                 │          "__kbn_is_tile_complete__": true
[00:07:09]                 │          "__kbn_metadata_feature__": true
[00:07:09]                 │          "__kbn_vector_shape_type_counts__": "{\"POINT\":2,\"LINE\":0,\"POLYGON\":0}"
[00:07:09]                 │       -  "fieldMeta": "{\"bytes\":{\"range\":{\"min\":9252,\"max\":9583,\"delta\":331},\"categories\":{\"categories\":[{\"key\":9583,\"count\":1},{\"key\":9252,\"count\":1}]}},\"machine.os.raw\":{\"categories\":{\"categories\":[{\"count\":1},{\"key\":\"ios\",\"count\":1}]}}}"
[00:07:09]                 │       +  "fieldMeta": "{\"machine.os.raw\":{\"categories\":{\"categories\":[{\"key\":\"ios\",\"count\":1},{\"count\":1}]}},\"bytes\":{\"range\":{\"min\":9252,\"max\":9583,\"delta\":331},\"categories\":{\"categories\":[{\"key\":9252,\"count\":1},{\"key\":9583,\"count\":1}]}}}"
[00:07:09]                 │        }
[00:07:09]                 │       
[00:07:09]                 │       at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:07:09]                 │       at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:07:09]                 │       at Context.<anonymous> (test/api_integration/apis/maps/get_tile.js:69:45)
[00:07:09]                 │       at runMicrotasks (<anonymous>)
[00:07:09]                 │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:07:09]                 │       at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:07:09]                 │ 
[00:07:09]                 │

Stack Trace

Error: expected { __kbn_metadata_feature__: true,
  __kbn_is_tile_complete__: true,
  __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
  __kbn_feature_count__: 2,
  fieldMeta: '{"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9583,"count":1},{"key":9252,"count":1}]}},"machine.os.raw":{"categories":{"categories":[{"count":1},{"key":"ios","count":1}]}}}' } to sort of equal { __kbn_feature_count__: 2,
  __kbn_is_tile_complete__: true,
  __kbn_metadata_feature__: true,
  __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
  fieldMeta: '{"machine.os.raw":{"categories":{"categories":[{"key":"ios","count":1},{"count":1}]}},"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9252,"count":1},{"key":9583,"count":1}]}}}' }
    at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/maps/get_tile.js:69:45)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '{\n' +
    '  "__kbn_feature_count__": 2\n' +
    '  "__kbn_is_tile_complete__": true\n' +
    '  "__kbn_metadata_feature__": true\n' +
    '  "__kbn_vector_shape_type_counts__": "{\\"POINT\\":2,\\"LINE\\":0,\\"POLYGON\\":0}"\n' +
    '  "fieldMeta": "{\\"bytes\\":{\\"range\\":{\\"min\\":9252,\\"max\\":9583,\\"delta\\":331},\\"categories\\":{\\"categories\\":[{\\"key\\":9583,\\"count\\":1},{\\"key\\":9252,\\"count\\":1}]}},\\"machine.os.raw\\":{\\"categories\\":{\\"categories\\":[{\\"count\\":1},{\\"key\\":\\"ios\\",\\"count\\":1}]}}}"\n' +
    '}',
  expected: '{\n' +
    '  "__kbn_feature_count__": 2\n' +
    '  "__kbn_is_tile_complete__": true\n' +
    '  "__kbn_metadata_feature__": true\n' +
    '  "__kbn_vector_shape_type_counts__": "{\\"POINT\\":2,\\"LINE\\":0,\\"POLYGON\\":0}"\n' +
    '  "fieldMeta": "{\\"machine.os.raw\\":{\\"categories\\":{\\"categories\\":[{\\"key\\":\\"ios\\",\\"count\\":1},{\\"count\\":1}]}},\\"bytes\\":{\\"range\\":{\\"min\\":9252,\\"max\\":9583,\\"delta\\":331},\\"categories\\":{\\"categories\\":[{\\"key\\":9252,\\"count\\":1},{\\"key\\":9583,\\"count\\":1}]}}}"\n' +
    '}',
  showDiff: true
}

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/maps/get_tile·js.apis Maps endpoints getTile should return vector tile containing document

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 15 times on tracked branches: https://github.com/elastic/kibana/issues/114417

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:07:07]         └-: Maps endpoints
[00:07:07]           └-> "before all" hook in "Maps endpoints"
[00:07:07]           └-> "before all" hook in "Maps endpoints"
[00:07:07]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "mappings.json"
[00:07:07]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "data.json.gz"
[00:07:07]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:07:07]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.22"
[00:07:07]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:07]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:07:07]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.20"
[00:07:07]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:07]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:07:07]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.21"
[00:07:07]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:07]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.21/7lhmYFLsSwCFnNVS_57WXQ] update_mapping [_doc]
[00:07:11]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.20/oL9CAIRFTpe-ZrJW7gowyw] update_mapping [_doc]
[00:07:17]             │ info progress: 12640
[00:07:18]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:07:18]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:07:18]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:07:18]             │ info [x-pack/test/functional/es_archives/maps/data] Loading "mappings.json"
[00:07:18]             │ info [x-pack/test/functional/es_archives/maps/data] Loading "data.json"
[00:07:18]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:18]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "geo_shapes"
[00:07:18]             │ debg [x-pack/test/functional/es_archives/maps/data] "geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1","max_result_window":"10001","max_inner_result_window":"101"}}
[00:07:18]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [drawing_data] creating index, cause [api], templates [], shards [1]/[0]
[00:07:18]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "drawing_data"
[00:07:18]             │ debg [x-pack/test/functional/es_archives/maps/data] "drawing_data" settings {"index":{"number_of_replicas":"0","number_of_shards":"1","max_result_window":"10001","max_inner_result_window":"101"}}
[00:07:18]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [meta_for_geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "meta_for_geo_shapes"
[00:07:19]             │ debg [x-pack/test/functional/es_archives/maps/data] "meta_for_geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:19]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [antimeridian_points] creating index, cause [api], templates [], shards [1]/[0]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "antimeridian_points"
[00:07:19]             │ debg [x-pack/test/functional/es_archives/maps/data] "antimeridian_points" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:19]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [antimeridian_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "antimeridian_shapes"
[00:07:19]             │ debg [x-pack/test/functional/es_archives/maps/data] "antimeridian_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:19]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [flights] creating index, cause [api], templates [], shards [1]/[0]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "flights"
[00:07:19]             │ debg [x-pack/test/functional/es_archives/maps/data] "flights" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:19]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [connections] creating index, cause [api], templates [], shards [1]/[0]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Created index "connections"
[00:07:19]             │ debg [x-pack/test/functional/es_archives/maps/data] "connections" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:07:19]             │ info [o.e.c.m.MetadataMappingService] [node-01] [meta_for_geo_shapes/kRjdSUN3SEycy8dUfSdpCQ] update_mapping [_doc]
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 4 docs into "geo_shapes"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 1 docs into "drawing_data"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 6 docs into "meta_for_geo_shapes"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "antimeridian_points"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "antimeridian_shapes"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 3 docs into "flights"
[00:07:19]             │ info [x-pack/test/functional/es_archives/maps/data] Indexed 4 docs into "connections"
[00:07:19]           └-: 
[00:07:19]             └-> "before all" hook in ""
[00:07:27]             └-: getTile
[00:07:27]               └-> "before all" hook for "should return vector tile containing document"
[00:07:27]               └-> should return vector tile containing document
[00:07:27]                 └-> "before each" hook: global before each for "should return vector tile containing document"
[00:07:27]                 └- ✖ fail: apis Maps endpoints  getTile should return vector tile containing document
[00:07:27]                 │       Error: expected { __kbn_metadata_feature__: true,
[00:07:27]                 │   __kbn_is_tile_complete__: true,
[00:07:27]                 │   __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
[00:07:27]                 │   __kbn_feature_count__: 2,
[00:07:27]                 │   fieldMeta: '{"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9583,"count":1},{"key":9252,"count":1}]}},"machine.os.raw":{"categories":{"categories":[{"count":1},{"key":"ios","count":1}]}}}' } to sort of equal { __kbn_feature_count__: 2,
[00:07:27]                 │   __kbn_is_tile_complete__: true,
[00:07:27]                 │   __kbn_metadata_feature__: true,
[00:07:27]                 │   __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
[00:07:27]                 │   fieldMeta: '{"machine.os.raw":{"categories":{"categories":[{"key":"ios","count":1},{"count":1}]}},"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9252,"count":1},{"key":9583,"count":1}]}}}' }
[00:07:27]                 │       + expected - actual
[00:07:27]                 │ 
[00:07:27]                 │          "__kbn_feature_count__": 2
[00:07:27]                 │          "__kbn_is_tile_complete__": true
[00:07:27]                 │          "__kbn_metadata_feature__": true
[00:07:27]                 │          "__kbn_vector_shape_type_counts__": "{\"POINT\":2,\"LINE\":0,\"POLYGON\":0}"
[00:07:27]                 │       -  "fieldMeta": "{\"bytes\":{\"range\":{\"min\":9252,\"max\":9583,\"delta\":331},\"categories\":{\"categories\":[{\"key\":9583,\"count\":1},{\"key\":9252,\"count\":1}]}},\"machine.os.raw\":{\"categories\":{\"categories\":[{\"count\":1},{\"key\":\"ios\",\"count\":1}]}}}"
[00:07:27]                 │       +  "fieldMeta": "{\"machine.os.raw\":{\"categories\":{\"categories\":[{\"key\":\"ios\",\"count\":1},{\"count\":1}]}},\"bytes\":{\"range\":{\"min\":9252,\"max\":9583,\"delta\":331},\"categories\":{\"categories\":[{\"key\":9252,\"count\":1},{\"key\":9583,\"count\":1}]}}}"
[00:07:27]                 │        }
[00:07:27]                 │       
[00:07:27]                 │       at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:07:27]                 │       at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:07:27]                 │       at Context.<anonymous> (test/api_integration/apis/maps/get_tile.js:69:45)
[00:07:27]                 │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:07:27]                 │       at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:07:27]                 │ 
[00:07:27]                 │

Stack Trace

Error: expected { __kbn_metadata_feature__: true,
  __kbn_is_tile_complete__: true,
  __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
  __kbn_feature_count__: 2,
  fieldMeta: '{"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9583,"count":1},{"key":9252,"count":1}]}},"machine.os.raw":{"categories":{"categories":[{"count":1},{"key":"ios","count":1}]}}}' } to sort of equal { __kbn_feature_count__: 2,
  __kbn_is_tile_complete__: true,
  __kbn_metadata_feature__: true,
  __kbn_vector_shape_type_counts__: '{"POINT":2,"LINE":0,"POLYGON":0}',
  fieldMeta: '{"machine.os.raw":{"categories":{"categories":[{"key":"ios","count":1},{"count":1}]}},"bytes":{"range":{"min":9252,"max":9583,"delta":331},"categories":{"categories":[{"key":9252,"count":1},{"key":9583,"count":1}]}}}' }
    at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/maps/get_tile.js:69:45)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '{\n' +
    '  "__kbn_feature_count__": 2\n' +
    '  "__kbn_is_tile_complete__": true\n' +
    '  "__kbn_metadata_feature__": true\n' +
    '  "__kbn_vector_shape_type_counts__": "{\\"POINT\\":2,\\"LINE\\":0,\\"POLYGON\\":0}"\n' +
    '  "fieldMeta": "{\\"bytes\\":{\\"range\\":{\\"min\\":9252,\\"max\\":9583,\\"delta\\":331},\\"categories\\":{\\"categories\\":[{\\"key\\":9583,\\"count\\":1},{\\"key\\":9252,\\"count\\":1}]}},\\"machine.os.raw\\":{\\"categories\\":{\\"categories\\":[{\\"count\\":1},{\\"key\\":\\"ios\\",\\"count\\":1}]}}}"\n' +
    '}',
  expected: '{\n' +
    '  "__kbn_feature_count__": 2\n' +
    '  "__kbn_is_tile_complete__": true\n' +
    '  "__kbn_metadata_feature__": true\n' +
    '  "__kbn_vector_shape_type_counts__": "{\\"POINT\\":2,\\"LINE\\":0,\\"POLYGON\\":0}"\n' +
    '  "fieldMeta": "{\\"machine.os.raw\\":{\\"categories\\":{\\"categories\\":[{\\"key\\":\\"ios\\",\\"count\\":1},{\\"count\\":1}]}},\\"bytes\\":{\\"range\\":{\\"min\\":9252,\\"max\\":9583,\\"delta\\":331},\\"categories\\":{\\"categories\\":[{\\"key\\":9252,\\"count\\":1},{\\"key\\":9583,\\"count\\":1}]}}}"\n' +
    '}',
  showDiff: true
}

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`customIntegrations`	77	75	-2
`fleet`	1107	1108	+1
total			-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	626.0KB	626.1KB	+103.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`customIntegrations`	6.4KB	6.4KB	-38.0B

Unknown metric groups

API count

id	before	after	diff
`customIntegrations`	95	91	-4
`fleet`	1207	1208	+1
total			-3

History

💔 Build #160119 failed bb76c02
💚 Build #159503 succeeded ca72459
💔 Build #159494 failed d2ab51e
💔 Build #159319 failed bbe6917

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck · 2021-10-12T20:13:46Z

the failing integration test is a known flaky Maps-test #114417. This one is resolved here #114689.

This PR is holding up other work, so using admin privileges to merge.

kibanamachine · 2021-10-12T20:18:00Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114429

thomasneirynck · 2021-10-12T20:21:44Z

Backport to 7.x blocked by backport of #114431

thomasneirynck · 2021-10-13T14:57:55Z

backport blocked by #114828

…tic#114429)

) (#114870)

thomasneirynck added 2 commits October 10, 2021 18:27

register epr categories

a4d1c49

Merge branch 'master' of github.com:elastic/kibana into fleet/dyn_cat…

e15f915

…egories

thomasneirynck added Feature:Unified Integrations Unified Integrations view feature v7.16.0 v8.0.0 WIP Work in progress Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 10, 2021

thomasneirynck added 3 commits October 10, 2021 19:19

remove unnecessary backend calls

db39c7a

reintroduce category counts

dc3f406

remove unused

bbe6917

thomasneirynck changed the title ~~[Fleet] Allow EPR to register new categories~~ [Fleet] Have EPR to register new categories Oct 10, 2021

thomasneirynck mentioned this pull request Oct 10, 2021

[Fleet] Unified Integrations view #93084

Closed

63 tasks

thomasneirynck changed the title ~~[Fleet] Have EPR to register new categories~~ [Fleet] Have EPR to register new categories / Show category counts Oct 11, 2021

type fixes

d2ab51e

thomasneirynck marked this pull request as ready for review October 11, 2021 12:39

thomasneirynck requested a review from a team as a code owner October 11, 2021 12:39

thomasneirynck requested a review from joshdover October 11, 2021 12:39

thomasneirynck requested a review from clintandrewhall October 11, 2021 12:39

thomasneirynck added chore release_note:skip Skip the PR/issue when compiling release notes and removed WIP Work in progress labels Oct 11, 2021

do cast correctly

ca72459

thomasneirynck changed the title ~~[Fleet] Have EPR to register new categories / Show category counts~~ [Fleet] Have EPR register new categories / Show category counts Oct 11, 2021

thomasneirynck requested a review from kpollich October 11, 2021 16:01

thomasneirynck mentioned this pull request Oct 11, 2021

[fleet] Add Integration Preference selector #114432

Merged

thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 11, 2021

thomasneirynck added 2 commits October 12, 2021 13:11

Merge branch 'master' of github.com:elastic/kibana into fleet/dyn_cat…

93d807e

…egories

remove redundant property

bb76c02

fix merge errors

5b6b406

remove trailing reference

9717119

nchaulet reviewed Oct 12, 2021

View reviewed changes

...plugins/fleet/public/applications/integrations/sections/epm/screens/home/category_facets.tsx Outdated Show resolved Hide resolved

thomasneirynck requested a review from nchaulet October 12, 2021 18:03

remove cruft

eb7d728

nchaulet approved these changes Oct 12, 2021

View reviewed changes

kpollich approved these changes Oct 12, 2021

View reviewed changes

thomasneirynck merged commit 1afac0f into elastic:master Oct 12, 2021

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Oct 13, 2021

[Fleet] Have EPR register new categories / Show category counts (elas…

89d8f9e

…tic#114429)

thomasneirynck mentioned this pull request Oct 13, 2021

[7.x] [Fleet] Have EPR register new categories / Show category counts (#114429) #114870

Merged

thomasneirynck added a commit that referenced this pull request Oct 13, 2021

[Fleet] Have EPR register new categories / Show category counts (#114429

488cc68

) (#114870)

Conversation

thomasneirynck commented Oct 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 11, 2021

Uh oh!

nchaulet commented Oct 12, 2021

Uh oh!

thomasneirynck commented Oct 12, 2021

Uh oh!

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

thomasneirynck commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Oct 12, 2021

💔 Backport failed

Uh oh!

thomasneirynck commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomasneirynck commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thomasneirynck commented Oct 10, 2021 •

edited

Loading

kibanamachine commented Oct 12, 2021 •

edited

Loading

thomasneirynck commented Oct 12, 2021 •

edited

Loading

thomasneirynck commented Oct 12, 2021 •

edited

Loading

thomasneirynck commented Oct 13, 2021 •

edited

Loading