Add Component Integration Test for Opening a Closed Index#114404
Merged
cuff-links merged 10 commits intoelastic:mainfrom Dec 20, 2021
Merged
Add Component Integration Test for Opening a Closed Index#114404cuff-links merged 10 commits intoelastic:mainfrom
cuff-links merged 10 commits intoelastic:mainfrom
Conversation
cuff-links
added
Feature:Index Management
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cuff-links
requested review from
cjcenizal,
sabarasaba,
sebelga and
yuliacech
and removed request for
cjcenizal
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sabarasaba
reviewed
Oct 12, 2021
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
Thanks for working on this @cuff-links! Changes LGTM, just had a suggestions for simplifying the button selector and maybe abstracting the clicking logic into a new action:
x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
Outdated
Show resolved
Hide resolved
3 tasks
yuliacech
reviewed
Nov 9, 2021
Contributor
yuliacech
left a comment
yuliacech
left a comment
There was a problem hiding this comment.
Hi @cuff-links, let me know if I can help you with this PR, it probably needs some updates since #114900 merged.
Contributor
Author
|
This PR is waiting on the merging of #120912 to correct the CI errors happening. |
Contributor
|
@elasticmachine merge upstream |
sebelga
reviewed
Dec 14, 2021
x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
Outdated
Show resolved
Hide resolved
…lidate boilerplate.
…/kibana into Add_CIT_For_Open_Index_Action
Contributor
Author
|
@elasticmachine merge upstream |
sabarasaba
requested changes
Dec 17, 2021
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
Thanks for fixing the tests @cuff-links! I left two small comments that I think we should address before merging 🚀
x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
Show resolved
Hide resolved
x-pack/plugins/index_management/__jest__/client_integration/helpers/test_subjects.ts
Outdated
Show resolved
Hide resolved
…/kibana into Add_CIT_For_Open_Index_Action
Member
|
@elasticmachine merge upstream |
sabarasaba
approved these changes
Dec 20, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport failed
To backport manually run: |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Dec 20, 2021
…4404) * Added Component Integration Test for Opening A closed Index. * Fixed open index test and changed the structure of the tests to consolidate boilerplate. * Fixed PR based on feedback. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Dec 20, 2021
…4404) * Added Component Integration Test for Opening A closed Index. * Fixed open index test and changed the structure of the tests to consolidate boilerplate. * Fixed PR based on feedback. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
cuff-links
pushed a commit
that referenced
this pull request
Dec 22, 2021
…4404) (#121708) * Add Component Integration Test for Opening a Closed Index (#114404) * Added Component Integration Test for Opening A closed Index. * Fixed open index test and changed the structure of the tests to consolidate boilerplate. * Fixed PR based on feedback. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts * Fixed test. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mibragimov
pushed a commit
to mibragimov/kibana
that referenced
this pull request
Dec 22, 2021
…4404) * Added Component Integration Test for Opening A closed Index. * Fixed open index test and changed the structure of the tests to consolidate boilerplate. * Fixed PR based on feedback. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
cuff-links
pushed a commit
that referenced
this pull request
Dec 23, 2021
…121706) * Added Component Integration Test for Opening A closed Index. * Fixed open index test and changed the structure of the tests to consolidate boilerplate. * Fixed PR based on feedback. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a component integration test that checks that we are able to click the open index button for a closed index and check the last request to ensure that it was made to the open index API.