[Security Solution] Add host isolation exception IPs UI by academo · Pull Request #113762 · elastic/kibana

academo · 2021-10-04T14:16:37Z

Summary

Related to #111253 and #113541

This follow up PR adds the capability of adding host isolation exceptions IPs.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…ation-exception-add

elasticmachine · 2021-10-06T13:47:13Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

…ation-exception-add

dasansol92

Left some minor comments but this is looking ⭐ 🔥

...y_solution/public/management/pages/host_isolation_exceptions/view/components/form_flyout.tsx

...gins/security_solution/public/management/pages/host_isolation_exceptions/store/middleware.ts

...y_solution/public/management/pages/host_isolation_exceptions/view/components/form_flyout.tsx

...on/public/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.tsx

dasansol92

LGTM, thanks for the changes 👍

academo · 2021-10-11T08:01:18Z

@elasticmachine merge upstream

ashokaditya

Looks great! I checked out the branch locally and took it for a spin. Works as expected.
🚀 🐑

note:
The error toasts for creation and deletion may need some more work. They are not at all similar in the message content. Also, I notice some notate the sentence end with a . and most others do not. I would suggest we keep the toast contents consistent.

Deletion failure:

We should either have a useful reason in the error toast or not have it at all.

Compare it with creation error toast which is very terse:

and the successful deletion toast

.../plugins/security_solution/public/management/pages/host_isolation_exceptions/store/action.ts

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/types.ts

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/utils.ts

...ution/public/management/pages/host_isolation_exceptions/view/components/form_flyout.test.tsx

academo · 2021-10-11T11:11:22Z

@ashokaditya thanks for pointing the message inconsistency on the toasts. I'll fix them in the upcoming edit PR and consult about the copy.

kibanamachine · 2021-10-11T13:20:24Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2301	2306	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.3MB	4.3MB	+18.4KB

History

💚 Build #159348 succeeded 07c624a
💛 Build #158792 was flaky d79ef0e
💚 Build #158767 succeeded de6e673
💔 Build #158788 failed 21dd6c7
💚 Build #158481 succeeded 0e2d84b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-11T13:23:43Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…14490) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>

academo added 4 commits October 1, 2021 14:49

Initial empty form to add an exception

b4ecec8

Merge remote-tracking branch 'upstream/master' into feature/host-isol…

da94c6e

…ation-exception-add

WIP add form construction

0fb4d41

Add code to handle the add form

c73b47f

academo added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.0 v8.0.0 labels Oct 4, 2021

academo and others added 15 commits October 5, 2021 09:36

Merge remote-tracking branch 'upstream/master' into feature/host-isol…

671faa0

…ation-exception-add

WIP create entry

a4775ce

Working add

1754d41

Add toast to create and failure

6fc871f

Add validation for ipv4 and CIDR format

0378a57

Reload the list of exceptions after adding

64669d8

Remove unused import

dcbb5df

Merge remote-tracking branch 'upstream/master' into feature/host-isol…

02b2f11

…ation-exception-add

Replace mockclear with mockreset

02cbe0b

Add tests for reducer and add host Isolation exception

becaa1a

Fix TS error

82a47aa

Firsts test for form

d18264e

Tests for form

3ccdf9e

Remove unused dependencies

138fca7

Add tests for for the form flyout

346dbf2

academo marked this pull request as ready for review October 6, 2021 13:47

academo requested a review from a team as a code owner October 6, 2021 13:47

academo requested review from paul-tavares and pzl October 6, 2021 13:47

academo removed the request for review from pzl October 6, 2021 13:47

academo requested a review from dasansol92 October 6, 2021 13:47

Esteban Beltran added 2 commits October 6, 2021 16:10

Add tests for the add button

0e2d84b

Merge remote-tracking branch 'upstream/master' into feature/host-isol…

de6e673

…ation-exception-add

dasansol92 reviewed Oct 7, 2021

View reviewed changes

Esteban Beltran added 2 commits October 7, 2021 10:49

Fix PR comments

e5e8b12

Handle onCancel directly on the form flyout

21dd6c7

academo requested a review from dasansol92 October 7, 2021 09:12

Fix dependency issue for hook

d79ef0e

dasansol92 approved these changes Oct 7, 2021

View reviewed changes

academo requested a review from ashokaditya October 7, 2021 14:28

Merge branch 'master' into feature/host-isolation-exception-add

07c624a

ashokaditya approved these changes Oct 11, 2021

View reviewed changes

Fix PR comments

6a697ea

academo enabled auto-merge (squash) October 11, 2021 11:17

academo merged commit 2ffbf6e into elastic:master Oct 11, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2021

[Security Solution] Add host isolation exception IPs UI (elastic#113762)

c93849b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine mentioned this pull request Oct 11, 2021

[7.x] [Security Solution] Add host isolation exception IPs UI (#113762) #114490

Merged

academo mentioned this pull request Oct 11, 2021

[Security Solution] Edit host isolation exception IP UI #114279

Merged

6 tasks

academo mentioned this pull request Oct 15, 2021

[Security Solution] Generate host isolation exceptions artifact #115160

Merged

2 tasks

Conversation

academo commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 6, 2021

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

academo commented Oct 11, 2021

Uh oh!

ashokaditya left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

academo commented Oct 11, 2021

Uh oh!

kibanamachine commented Oct 11, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

kibanamachine commented Oct 11, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

academo commented Oct 4, 2021 •

edited

Loading

ashokaditya left a comment •

edited

Loading