[Security Solution] host isolation exceptions delete item UI by academo · Pull Request #113541 · elastic/kibana

academo · 2021-09-30T14:18:26Z

Summary

Follow up to #111253

Adds the option to delete a host isolation exception IP.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…ation_ips_whitelist

This reverts commit 43c3a61.

…ation_ips_whitelist

academo · 2021-10-01T08:05:16Z

@elasticmachine merge upstream

dasansol92

This is looking awesome!! 🤩
Just a change suggestion

...on/public/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.tsx

…isolation_exceptions/view/host_isolation_exceptions_list.tsx Co-authored-by: David Sánchez <davidsansol92@gmail.com>

academo · 2021-10-04T08:05:27Z

@elasticmachine merge upstream

dasansol92

🔥

academo · 2021-10-04T15:03:57Z

@elasticmachine merge upstream

ashokaditya

I have a few suggestions and questions. Otherwise, it looks awesome.

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/types.ts

...lugins/security_solution/public/management/pages/host_isolation_exceptions/store/selector.ts

...tion/public/management/pages/host_isolation_exceptions/view/components/delete_modal.test.tsx

.../plugins/security_solution/public/management/pages/host_isolation_exceptions/store/action.ts

…ation-exceptions-delete

ashokaditya

🚀 🐑

kibanamachine · 2021-10-05T13:50:41Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2292	2293	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.3MB	4.3MB	+4.2KB

History

💔 Build #157967 failed 04fa1e7
💚 Build #157595 succeeded 146d1d3
💔 Build #157403 failed 4d61098
💛 Build #157110 was flaky d4750dd
💚 Build #157009 succeeded e8a3ee3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

kibanamachine · 2021-10-07T13:55:00Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113541 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-10-08T14:04:58Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113541 or prevent reminders by adding the backport:skip label.

#114435) Co-authored-by: David Sánchez <davidsansol92@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: David Sánchez <davidsansol92@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

academo added 30 commits September 20, 2021 09:43

Add isolation_ips_whitelist to the exception list endpoint types

1773c79

Add menu item for host isolation exceptions

71c6bf4

Rename list id for host isolation exceptions

ae332c9

Add boilerplate code for stores and middlewares

406f6b0

Basic middleware setup for host isolation exceptions

819f97a

WIP list excepted ips

e353289

Fix entries types for loading date

5207d59

Broken TS

1d6037e

Fix TS errors related to AsyncResourceState problems with actions

c470ac1

Reducer WIP

216ffb1

Add selectors to load data on the list display

0ce0223

Showing the list of cards now, pagination not working

8497e6c

Added working pagination

7496082

Implement search functionality

8f44539

Dispatch loading and error states

81522cd

remove todo comment

03041b2

Clean code for PR

76ec46e

Fix unit tests

dc8a8a5

Fix Exceptions Enum

84eecf7

Add a feature flag for the isolation exceptions menu

d1e79f3

Fix test failing due to feature flag

43c3a61

Merge remote-tracking branch 'upstream/master' into feature/host_isol…

4169d44

…ation_ips_whitelist

Add middleware and reducers tests

4d3fcab

Replace ItemExceptionCard by ArtifactCard

c398b11

Remove experimental flag

5310cf2

Revert "Fix test failing due to feature flag"

f6b9af5

This reverts commit 43c3a61.

Fix loading state for middleware

fb63309

Add empty state and test ids

01fc428

Add unit tests for host isolation exceptions lists component

021679a

Merge remote-tracking branch 'upstream/master' into feature/host_isol…

a768a2e

…ation_ips_whitelist

Merge branch 'master' into feature/host-isolation-exceptions-delete

e8a3ee3

dasansol92 reviewed Oct 1, 2021

View reviewed changes

...on/public/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/security_solution/public/management/pages/host_…

d4750dd

…isolation_exceptions/view/host_isolation_exceptions_list.tsx Co-authored-by: David Sánchez <davidsansol92@gmail.com>

Merge branch 'master' into feature/host-isolation-exceptions-delete

4d61098

academo requested a review from dasansol92 October 4, 2021 08:05

dasansol92 approved these changes Oct 4, 2021

View reviewed changes

academo mentioned this pull request Oct 4, 2021

[Security Solution] Add host isolation exception IPs UI #113762

Merged

6 tasks

Merge branch 'master' into feature/host-isolation-exceptions-delete

146d1d3

academo requested review from ashokaditya and removed request for parkiino October 4, 2021 15:04

ashokaditya reviewed Oct 5, 2021

View reviewed changes

academo added 2 commits October 5, 2021 13:14

Merge remote-tracking branch 'upstream/master' into feature/host-isol…

5e6c908

…ation-exceptions-delete

Fix minor issues from PR

04fa1e7

academo requested a review from ashokaditya October 5, 2021 11:27

ashokaditya approved these changes Oct 5, 2021

View reviewed changes

academo enabled auto-merge (squash) October 5, 2021 11:28

Fix eslint

5c46368

academo merged commit 9902cbd into elastic:master Oct 5, 2021

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2021

academo mentioned this pull request Oct 11, 2021

[7.x] [Security Solution] host isolation exceptions delete item UI (#113541) #114435

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021

This was referenced Oct 11, 2021

[Security Solution] Edit host isolation exception IP UI #114279

Merged

[Security Solution] Generate host isolation exceptions artifact #115160

Merged

Conversation

academo commented Sep 30, 2021

Summary

Checklist

Uh oh!

academo commented Oct 1, 2021

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

academo commented Oct 4, 2021

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

academo commented Oct 4, 2021

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 5, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

kibanamachine commented Oct 7, 2021

Uh oh!

kibanamachine commented Oct 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants