Bumping EUI to 39.0.0 by breehall · Pull Request #113633 · elastic/kibana

breehall · 2021-10-01T15:02:29Z

Summary

eui@38.0.1 ⏩ ~~eui@38.2.0~~ eui@39.0.0

`39.0.0`

Added maxWidth prop to EuiTour, made subtitle optional, and fixed heading levels and footer background (#5225)
Updated tint, shade, saturate, desaturate, and makeHighContrastColor utility functions to maintain color format supplied (#5230)
Converted generated icon files to Typescript, eliminating the last .js files in our source files (#5212)

Bug fixes

Fixed tick and level alignment in Eui[Dual]Range (#5181)
Fixed multiple accessibility issues in EuiBasicTable and EuiInMemoryTable (#5237, #5241)
Fixed missing i18n token in EuiBasicTable's no items message (#5242)

Breaking changes

Removed boolean from EuiTour's minWidth type (#5225)

`38.2.0`

Updated EuiRangeLevel color property to accept CSS color values (#5171)

Bug fixes

Fixed logo icons with static SVG IDs causing accessibility errors when multiples of the same logo were present (#5204)
Fixed several EuiDataGrid console errors that occur on column drag/drop reorder (#5209)

Reverts

Reverted EuiScreenReaderOnly left positioning change due to Selenium issues (#5215)

`38.1.0`

Fixed the title prop EuiButtonGroup to automatically display the label provided (#5199)
Updated barSeriesStyle.displayValue of the elastic-charts Theme for better default styles (#4845)
Added a configuration parameter to the EuiMarkdownEditor plugin functions to exclude custom plugins (#5147)
Added auto as value for defaultHeight in prop rowHeightsOptions in EuiDataGrid that allows to content auto-fit to row (#4958)
Updated titleProps and descriptionProps on EuiDescriptionList to extend CommonProps (#5166)
Added the ability to return visibleOptions from EuiSelectable by using onSearch (#5178)

Bug fixes

Fixed EuiDataGrid focus ring to be contained in the cell (#5194)
Fixed EuiDataGrid cells when focused getting a higher z-index which was causing long content to overlap surrounding cells (#5194)
Replaced the EuiMarkdownEditor help syntax modal with a popover when no custom plugins are available (#5147)
Fixed multiple components unnecessarily rerendering generated IDs on every update (#5195, #5196, #5197, #5200, #5201)

Theme: Amsterdam

Fixed border-radius and increased font-weight for EuiButtonGroup (#4993)
Increased contrast of text color for text colored EuiButton and EuiButtonIcon (#5177)

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts

…onflict in availability_reporting.test.tsx

…pgrade-38.2.0 Merging in the latest code from the Master branch

…ndle an issue found with a functional test during the original upgrade

… addition in EUI v. 39.0.0

…pgrade-38.2.0 Merging in the latest code from the Master branch

breehall · 2021-10-07T19:53:24Z

@elasticmachine merge upstream

sabarasaba

stack management changes LGTM 🚀 didn't test locally

jbudz

license checker config LGTM

smith

APM changes look good

thompsongl · 2021-10-11T16:12:58Z

@elasticmachine merge upstream

thompsongl · 2021-10-11T18:23:47Z

@elasticmachine merge upstream

cee-chen · 2021-10-11T21:01:18Z

@elasticmachine merge upstream

thompsongl · 2021-10-12T01:02:55Z

@elasticmachine merge upstream

VladLasitsa · 2021-10-12T13:33:16Z

@elasticmachine merge upstream

kibanamachine · 2021-10-12T15:38:50Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	-1.0B
`canvas`	1.0MB	1.0MB	-1.0B
`cloud`	12.3KB	12.3KB	-1.0B
`enterpriseSearch`	1.4MB	1.4MB	-1.0B
`fileUpload`	673.4KB	673.4KB	-1.0B
`graph`	403.3KB	403.3KB	-1.0B
`infra`	938.4KB	938.4KB	-1.0B
`ingestPipelines`	453.1KB	453.1KB	-1.0B
`kibanaReact`	203.5KB	203.5KB	-2.0B
`lens`	1.0MB	1.0MB	-1.0B
`maps`	2.7MB	2.7MB	-1.0B
`mapsEms`	174.0KB	174.0KB	-1.0B
`ml`	3.6MB	3.6MB	-1.0B
`reporting`	43.9KB	43.9KB	-1.0B
`security`	514.6KB	514.6KB	-1.0B
`securitySolution`	4.6MB	4.6MB	-1.0B
`uiActionsEnhanced`	128.8KB	128.8KB	-1.0B
`uptime`	568.6KB	568.6KB	-1.0B
`visTypeTimeseries`	485.8KB	485.8KB	-1.0B
`visTypeVega`	1.9MB	1.9MB	-2.0B
`visTypeVislib`	373.7KB	373.7KB	-1.0B
total			-23.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	300.5KB	301.0KB	+468.0B
`fieldFormats`	49.0KB	49.0KB	-1.0B
`fleet`	104.7KB	104.7KB	-1.0B
`kbnUiSharedDeps-css`	596.7KB	597.0KB	+321.0B
`kbnUiSharedDeps-npmDll`	5.1MB	5.1MB	+18.3KB
`kbnUiSharedDeps-srcJs`	3.8MB	3.8MB	-1.0B
`kibanaUtils`	85.8KB	85.7KB	-1.0B
`share`	54.0KB	54.0KB	-1.0B
total			+19.1KB

History

💔 Build #159796 failed f2394b2
💔 Build #159720 failed d13120a
💔 Build #159645 failed dd4ccbb
💔 Build #159598 failed 54726ea
💚 Build #159244 succeeded 379acdd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic

Uptime LGTM

breehall · 2021-10-12T16:41:03Z

Hey @elastic/kibana-presentation, @elastic/kibana-reporting-services, @pzl
Do you mind reviewing this PR to see if there are any concerns or questions with the upgrade of EUI in Kibana? I'd be happy to answer any questions you have. 😄

breehall · 2021-10-12T21:10:50Z

Merging this PR as the remaining reviews are snapshot related

* Upgraded the version of EUI to 38.2.0 from 38.0.1 * Updated the i18n mappings required for EUI v.38.2.0 * Update i18n snapshots and resolve linting error * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Resolve linting error in i18n mapping file * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Update plugin snapshots * Resolve merge conflict in license_checker config.ts file * Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade * Updated the i18n mapping for EUI v.39.0.0 * Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0 * Updated test cases marked as obsolete by CI * Update src/dev/license_checker/config.ts Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>

kibanamachine · 2021-10-12T21:13:50Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Upgraded the version of EUI to 38.2.0 from 38.0.1 * Updated the i18n mappings required for EUI v.38.2.0 * Update i18n snapshots and resolve linting error * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Resolve linting error in i18n mapping file * Removed html_id_generator mocks. Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts * Update plugin snapshots * Resolve merge conflict in license_checker config.ts file * Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade * Updated the i18n mapping for EUI v.39.0.0 * Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0 * Updated test cases marked as obsolete by CI * Update src/dev/license_checker/config.ts Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed. Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Bree Hall <40739624+breehall@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>

breehall added 2 commits October 1, 2021 10:25

Upgraded the version of EUI to 38.2.0 from 38.0.1

a298fb9

Updated the i18n mappings required for EUI v.38.2.0

69ee19c

breehall added auto-backport Deprecated - use backport:version if exact versions are needed EUI release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.16.0 labels Oct 1, 2021

breehall added 2 commits October 4, 2021 13:20

Update i18n snapshots and resolve linting error

d44b789

breehall force-pushed the eui-upgrade-38.2.0 branch from bfd7d5f to 8a29a96 Compare October 4, 2021 17:26

Resolve linting error in i18n mapping file

1973fc9

cee-chen mentioned this pull request Oct 4, 2021

[EuiBasicTable] Fix duplicate ID in EuiBasicTable's Select All checkbox(es) elastic/eui#5237

Merged

7 tasks

breehall added 7 commits October 4, 2021 16:27

Update plugin snapshots

ca1991e

Merging in the latest code from the master branch and resolve merge c…

eea8204

…onflict in availability_reporting.test.tsx

Resolve merge conflict in license_checker config.ts file

308c7ca

Merge branch 'master' of https://github.com/elastic/kibana into eui-u…

4380434

…pgrade-38.2.0 Merging in the latest code from the Master branch

Upgrade EUI to version 39.0.0 from the original target (38.2.0) to ha…

a9cf44b

…ndle an issue found with a functional test during the original upgrade

Updated the i18n mapping for EUI v.39.0.0

432b23f

breehall changed the title ~~Bumping EUI to 38.2.0~~ Bumping EUI to ~38.2.0~ 39.0.0 Oct 6, 2021

breehall changed the title ~~Bumping EUI to ~38.2.0~ 39.0.0~~ Bumping EUI to 39.0.0 Oct 6, 2021

breehall added 3 commits October 6, 2021 15:27

Update various snapshots to account for the an i18n translation token…

fb88b04

… addition in EUI v. 39.0.0

Updated test cases marked as obsolete by CI

71233e5

Merge branch 'master' of https://github.com/elastic/kibana into eui-u…

f6833eb

…pgrade-38.2.0 Merging in the latest code from the Master branch

Merge branch 'master' into eui-upgrade-38.2.0

6a940f5

breehall marked this pull request as ready for review October 7, 2021 22:03

breehall requested a review from a team October 7, 2021 22:03

breehall requested review from a team as code owners October 7, 2021 22:03

matschaffer approved these changes Oct 11, 2021

View reviewed changes

pgayvallet approved these changes Oct 11, 2021

View reviewed changes

sabarasaba approved these changes Oct 11, 2021

View reviewed changes

jbudz approved these changes Oct 11, 2021

View reviewed changes

smith approved these changes Oct 11, 2021

View reviewed changes

Merge branch 'master' into eui-upgrade-38.2.0

54726ea

Merge branch 'master' into eui-upgrade-38.2.0

dd4ccbb

Merge branch 'master' into eui-upgrade-38.2.0

d13120a

Merge branch 'master' into eui-upgrade-38.2.0

f2394b2

academo approved these changes Oct 12, 2021

View reviewed changes

Merge branch 'master' into eui-upgrade-38.2.0

a291847

justinkambic approved these changes Oct 12, 2021

View reviewed changes

pzl approved these changes Oct 12, 2021

View reviewed changes

breehall merged commit a51545e into master Oct 12, 2021

kibanamachine mentioned this pull request Oct 12, 2021

[7.x] Bumping EUI to 39.0.0 (#113633) #114726

Merged

orhantoy mentioned this pull request Oct 19, 2021

[App Search, Crawler] Fix validation step panel padding/whitespace #115542

Merged

spalger deleted the eui-upgrade-38.2.0 branch May 8, 2022 22:04

Conversation

breehall commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

39.0.0

38.2.0

38.1.0

Uh oh!

breehall commented Oct 7, 2021

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Oct 11, 2021

Uh oh!

thompsongl commented Oct 11, 2021

Uh oh!

cee-chen commented Oct 11, 2021

Uh oh!

thompsongl commented Oct 12, 2021

Uh oh!

VladLasitsa commented Oct 12, 2021

Uh oh!

kibanamachine commented Oct 12, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

breehall commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

breehall commented Oct 12, 2021

Uh oh!

kibanamachine commented Oct 12, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

breehall commented Oct 1, 2021 •

edited

Loading

`39.0.0`

`38.2.0`

`38.1.0`

breehall commented Oct 12, 2021 •

edited

Loading