Changed color utility functions to maintain color format supplied #5230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
changed the title
.css() or rgb
21 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5230/ |
thompsongl
approved these changes
Oct 1, 2021
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM
I pushed a commit with a little helper function
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5230/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in our Global Values page any time we were doing color calculations on hex values, the
rgb()value was output which in turn confused the color picker. So I've updated these functions to attempt to maintain the same format that was passed in except formakeHighContrast()since we don't support alpha values anyway.Before
After
Color utility page showing input vs output
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for any docs examplesEmotion is not working[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes