Merged
Conversation
Add `?*` to the end of request aliases in instances table tests. Not sure why or when these started failing. It could be that the version of Cypress we're using changed and this behavior changed.
smith
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Sep 28, 2021
Member
sorenlouv
left a comment
sorenlouv
left a comment
There was a problem hiding this comment.
I don't understand why this fixes it (and why it was not needed previously) but lgtm
Contributor
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2021
Add `?*` to the end of request aliases in instances table tests. elastic#104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM.
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2021
Add `?*` to the end of request aliases in instances table tests. #104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM. Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
?*to the end of request aliases in instances table tests.#104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM.