Bump cypress@8.4.1#104301
Merged
patrykkopycinski merged 32 commits intoelastic:masterfrom Sep 28, 2021
Merged
Conversation
patrykkopycinski
added
v8.0.0
release_note:skip
…-7.6.0 # Conflicts: # package.json # packages/kbn-pm/dist/index.js # x-pack/plugins/security_solution/cypress/integration/overview/overview.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines/notes_tab.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines/open_timeline.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines/query_tab.spec.ts # x-pack/plugins/security_solution/cypress/objects/exception.ts # x-pack/plugins/security_solution/cypress/objects/rule.ts # x-pack/plugins/security_solution/cypress/objects/timeline.ts
Contributor
Author
|
@elasticmachine merge upstream |
…-7.6.0 # Conflicts: # package.json # packages/kbn-pm/dist/index.js # yarn.lock
…-7.6.0 # Conflicts: # x-pack/plugins/security_solution/cypress/objects/timeline.ts # x-pack/plugins/security_solution/package.json # yarn.lock
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
MadameSheema
approved these changes
Sep 27, 2021
| ], | ||
| "compilerOptions": { | ||
| "target": "es5", | ||
| "lib": ["es5", "dom"], |
Contributor
There was a problem hiding this comment.
This is interesting changes, does this give us new abilities such as being able to use ?? where before we couldn't?
Contributor
There was a problem hiding this comment.
From chat this does seem to be the case 👍
FrankHassanabad
approved these changes
Sep 27, 2021
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
LGTM,
- Looked it over, asked a few curiosity questions, nothing major
Thanks for this upgrade. This is going to be a big upgrade for our flakes and tests I'm sure. I bet this was harder than you made it all look, so thanks a million!
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2021
Merged
smith
added a commit
that referenced
this pull request
Sep 28, 2021
Add `?*` to the end of request aliases in instances table tests. #104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2021
Add `?*` to the end of request aliases in instances table tests. elastic#104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM.
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2021
Add `?*` to the end of request aliases in instances table tests. #104301 upgraded Cypress to a newer version that required this, but the APM E2E tests were not run because there were no changes to any files in APM. Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps Cypress to the most recent version https://docs.cypress.io/guides/references/changelog
The biggest changes to notice:
cy.interceptrequires*suffixstubSearchStrategyApiwas removed in favor of test data (it's tricky to stub search strategy properly)