[Security Solutions] Search results deepLinks fix inconsistency#113046
Merged
semd merged 5 commits intoelastic:masterfrom Sep 29, 2021
Merged
[Security Solutions] Search results deepLinks fix inconsistency#113046semd merged 5 commits intoelastic:masterfrom
semd merged 5 commits intoelastic:masterfrom
Conversation
semd
added
bug
…ty_search_results_consistency
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
1 task
Contributor
|
I think we need to change this logic because of this comment in my PR |
Contributor
|
@elasticmachine merge upstream |
angorayc
approved these changes
Sep 29, 2021
Contributor
angorayc
left a comment
angorayc
left a comment
There was a problem hiding this comment.
Tested locally, all looks good. Thank you Sergi!
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @semd |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
…tic#113046) * deepLinks grouped and refactor * use translations * use Set and renaming Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
) (#113395) * deepLinks grouped and refactor * use translations * use Set and renaming Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Contributor
|
@semd can you please backport this into 7.15? thanks! |
semd
added a commit
to semd/kibana
that referenced
this pull request
Sep 30, 2021
…tic#113046) * deepLinks grouped and refactor * use translations * use Set and renaming Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/public/app/deep_links/index.test.ts
semd
added a commit
that referenced
this pull request
Oct 1, 2021
#113046) (#113537) * [Security Solutions] Search results deepLinks fix inconsistency (#113046) * deepLinks grouped and refactor * use translations * use Set and renaming Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/public/app/deep_links/index.test.ts * limit updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solves: #107123
Refactor
The current approach using the
baseandpremiumentries in a separate object did not allow to have nested premium sections, which was needed since all the Investigate and Explore sub-sections needed to be moved one level deeper.Hence, the
PREMIUM_DEEP_LINK_IDShas been created and thegetDeepLinksfunction now uses a recursive approach to build the "filtered" deep links object.Gravacio.de.pantalla.2021-09-27.a.les.10.02.00.mov
Checklist
Delete any items that are not applicable to this PR.