[Security Solution] Top-level Cases feature under the Security#112980
[Security Solution] Top-level Cases feature under the Security#112980XavierM merged 13 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
|
@elasticmachine merge upstream |
…M/kibana into upgrade-cases-security-privileges
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
I have a conflicting PR #113046 but no worries I will sync mine when this one is merged
jonathan-buttner
left a comment
There was a problem hiding this comment.
Code changes look good. I tested this locally too 👍
One thing I did notice that is slightly different behavior than before is that a user can have cases read or all and not have security and they will not be able to access cases because the entire security plugin will be disabled.
This is slightly different from how it worked as a sub feature because it was not possible to grant cases privileges when the security privilege was set to none
The toggle is grayed out:
|
@jonathan-buttner that's a valid point, let me see what I can do here and let me talk to @semd and see if we can register cases routes outside. |
|
@XavierM
Currently, the Cases routes are defined outside the plugin, the SecuritySolutions and O11y plugins define the Cases routes and deep links, and then they import and render the Cases pages accordingly. This is something we'd like to change and define all the routes within the Cases plugin, so there is only one entry point, but right now it is the parent plugin responsibility. So, maybe another option would be to register and mount SecuritySolutions plugin anyway (even I am not sure how to do it), and have only the Cases pages visible, hiding the rest of the sections. Or otherwise, keep the same precedence and not show Cases if Security is disabled, while we prepare the Cases plugin to be rendered alone. 🤷♂️ What do you think? @cnasikas |
jportner
left a comment
There was a problem hiding this comment.
LGTM, a couple minor nits below.
Discussed offline that a follow-on PR will be submitted to deal with a user who has access to Cases but not the Security Solution.
x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts
Outdated
Show resolved
Hide resolved
620e616 to
19897a7
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Should have the same query and open the timeline modal.Create a timeline from a template Should have the same query and open the timeline modalStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |


Summary
Create new top-level Cases feature under the Security category just for 8.x, we will have a follow up PR for 7.x to deprecate the sub feature of cases into the top level feature
#109158
Checklist
Delete any items that are not applicable to this PR.