Skip to content

[APM] Changes link version to master in APM links#111685

Merged
szabosteve merged 3 commits intoelastic:masterfrom
szabosteve:fix.apm.links
Sep 9, 2021
Merged

[APM] Changes link version to master in APM links#111685
szabosteve merged 3 commits intoelastic:masterfrom
szabosteve:fix.apm.links

Conversation

@szabosteve
Copy link
Contributor

Summary

This PR hard-codes the version of the APM links in the docs links service to master instead of using ${DOC_LINK_VERSION}. This is necessary because the APM books don't have a 7x version built, so the Kibana link check fails on 7x.

Related to: elastic/docs#2209

@szabosteve szabosteve added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 9, 2021
@szabosteve szabosteve requested a review from a team as a code owner September 9, 2021 08:24
@szabosteve szabosteve added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@szabosteve szabosteve requested a review from lcawl September 9, 2021 08:26
@elastic elastic deleted a comment from kibanamachine Sep 9, 2021
@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 408.1KB 408.1KB -45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve merged commit cac4957 into elastic:master Sep 9, 2021
@szabosteve szabosteve deleted the fix.apm.links branch September 9, 2021 13:10
szabosteve added a commit to szabosteve/kibana that referenced this pull request Sep 9, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
szabosteve added a commit that referenced this pull request Sep 9, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants