Skip to content

Adds apm_docs variable to Kibana link checker#2209

Merged
szabosteve merged 9 commits intoelastic:masterfrom
szabosteve:apm.link.check
Sep 9, 2021
Merged

Adds apm_docs variable to Kibana link checker#2209
szabosteve merged 9 commits intoelastic:masterfrom
szabosteve:apm.link.check

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Sep 3, 2021

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the test is fixed.

@szabosteve szabosteve changed the title Adds apm_get_started variable to Kibana link checker Adds apm_docs variable to Kibana link checker Sep 3, 2021
@szabosteve szabosteve requested a review from gtback September 3, 2021 15:07
@szabosteve
Copy link
Contributor Author

@gtback @lcawl

I modified APM_GET_STARTED to APM_DOCS which is a constant with broader usability. However, I'm not sure anymore that the check that I add in this PR is correct. Please have another look at this when the time permits. Thank you!

@szabosteve szabosteve requested a review from gtback September 6, 2021 07:56
Co-authored-by: Greg Back <1045796+gtback@users.noreply.github.com>
@szabosteve szabosteve merged commit 7fb0eff into elastic:master Sep 9, 2021
@szabosteve szabosteve deleted the apm.link.check branch September 9, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants