[App Search] use setSuccessMessage instead of flashSuccessToast for successful crawler domain deletes

[byronhulcher]

Summary

Realized this today.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[byronhulcher]

Cheers @orhantoy!

[cee-chen]

Just curious, why? All our other success messages in Kibana are now using toasts, so this seems like a UX inconsistency.

[byronhulcher]

@constancecchen so I was confused because in 7.x we use setSuccessMessage but in master we use flashSuccessToast. I thought I remembered us discussing that we were using too many toasts. I see now that when [App Search] Success toast polish pass was backported it did not include crawler_overview_logic.ts or crawler_overview_logic.test.ts in [7.x] [App Search] Success toast polish pass (#103410).

I will file a PR against 7.x to use flashSuccessToast universally

[byronhulcher]

I've created #107948

[cee-chen]

Right yeah, crawler_overview_logic wasn't in 7.x at the time (but was in master) so I had to manually fix the merge conflict in the backport.

Honestly, I haven't been a huge fan of how the crawler backport situation played out with 7.x (a decent amount of conflicts/headaches) and going forward would generally suggest trying to keep master and 7.x 1:1 as possible and either utilizing dev environment checks or making manual "hide X feature" PRs to release branches only, like what I did for the entire plugin throughout 7.14 (#98197).

[cee-chen]

I remembered us discussing that we were using too many toasts

Also want to clarify on this - we (Enterprise Search) are not using too many toasts - we only currently use toasts for success messages. What we want to avoid is using toasts for error messages, which have potentially poorer UX with users missing messages before they disappear.

Other Kibana plugins/solutions use error toasts, we do not currently and still use flash messages callouts for 99% of our errors. The exception to this is transient polling errors, which will either recur every x seconds or fix itself on the next poll (if connection is restored) and thus do not have the same issue of being missed.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 057aef4
• Storybooks Preview

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream